Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processingTimeout and redeliverInterval units in the docs don't seem to match code. #4048

Closed
francescortiz opened this issue Feb 28, 2024 · 0 comments · Fixed by #4049
Closed
Assignees
Labels
content/incorrect-information Content in the docs is incorrect

Comments

@francescortiz
Copy link

Describe the issue
The documentation about processingTimeout and redeliverInterval states that the format is "15s", but the implementation seems to expect milliseconds with no unit:
https://github.com/dapr/components-contrib/blob/fff4d41fb76bcc81da09b875ee0966bcaca62b2b/common/component/redis/redis.go#L141

URL of the docs
https://docs.dapr.io/reference/components-reference/supported-pubsub/setup-redis-pubsub/

Expected content

Field Required Details Example
redeliverInterval N The interval in milliseconds between checks for pending messages to redeliver. Defaults to "60000""0" disables redelivery. "5000"
processingTimeout N The amount of time in milliseconds that a message must be pending before attempting to redeliver it. Defaults to "15000""0" disables redelivery. "600000"

Additional context
The behavior in our cluster matches the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content/incorrect-information Content in the docs is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants