Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce golangci-lint #168

Closed
daixiang0 opened this issue May 26, 2021 · 2 comments · Fixed by #177
Closed

Introduce golangci-lint #168

daixiang0 opened this issue May 26, 2021 · 2 comments · Fixed by #177
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@daixiang0
Copy link
Member

Is your feature request related to a problem? Please describe.

I do not see any lint for this, enable lint makes project better I think.

Describe the solution you'd like

Introduce golangci-lint.

I have done at local, If possible, I will post it.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@daixiang0 daixiang0 added the enhancement New feature or request label May 26, 2021
@berndverst
Copy link
Member

Hello @daixiang0,

There is already make lint in this project. Also the golangci-lint is run when pushing a commit by this Github Workflow: https://github.com/dapr/go-sdk/blob/main/.github/workflows/test-on-push.yaml#L41

Do you need anything else? Maybe we can update this to [push, pull_request] instead. But a PR from a fork doesn't trigger the Workflow by default anyway.

Best if people just remember to manually run make lint.

@daixiang0
Copy link
Member Author

Yep, I think we should add it to CI in pr, we have little push event right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants