Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for promises #12

Closed
marcus-sa opened this issue Oct 18, 2019 · 3 comments
Closed

Add support for promises #12

marcus-sa opened this issue Oct 18, 2019 · 3 comments

Comments

@marcus-sa
Copy link

Promise support is a must have and is definitely preferred over callbacks.

@brendandburns
Copy link
Contributor

@marcus-sa This code is generated by the gRPC code generator. Please see the issue here:

grpc/grpc-node#54

Discussing why they still use callbacks.

I'm going to investigate grpc-helper and see if we can use that.

Failing at that, hand-written code to help with this is also ok...

@XavierGeerinck
Copy link
Contributor

@marcus-sa This code is generated by the gRPC code generator. Please see the issue here:

grpc/grpc-node#54

Discussing why they still use callbacks.

I'm going to investigate grpc-helper and see if we can use that.

Failing at that, hand-written code to help with this is also ok...

Was looking at the same thing for promises, apparently there is a bug that has to get resolved first (PR is open at: https://github.com/xizhibei/grpc-helper/pull/9/files#diff-3cafb86a5b0a9d0916a7fed543a1fb53)

@XavierGeerinck
Copy link
Contributor

Promises have been added in the entire library now, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants