-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update testing steps in CI #200
[WIP] Update testing steps in CI #200
Conversation
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=========================================
Coverage ? 26.98%
=========================================
Files ? 70
Lines ? 6141
Branches ? 976
=========================================
Hits ? 1657
Misses ? 4102
Partials ? 382 Continue to review full report at Codecov.
|
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 could you walk me through the idea you are executing here? Also: I see the replacement with TestIt, but I think the util is commented out? |
@XavierGeerinck, it's currently a WIP, I was trying out different things. The first approach is something similar to what conformance tests in https://github.com/dapr/components-contrib do. We can set an environment variable on failure, and use that to detect in the next step. This is a hack, but should be a good short term solution till we reach the second approach. Also, the code is commented because the CI started going crazy in an infinite loop, didn't want it to break, LOL. The second approach will be like what Java SDK/.NET SDK do today. Reference: https://github.com/dapr/java-sdk/tree/master/sdk-tests/src/test/java/io/dapr/it. They have an elaborate test runner, that is responsible for starting up Dapr The second approach is better than first, but will take more time. I think once this is fixed, dapr/cli#684, our original method should work, but that change might require a lot of time since people would already have dependencies in place. |
As discusses offline, we are leaning to provide a short-term fix using first approach, and then plan the second approach as a long-term fix. |
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Description
Sorry for slightly multi-functional PR. The changes are closely related to each other. It does the following:
utils
unit tests topackage.json
Issue reference
Please reference the issue this PR will close #193 and close #197
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: