Skip to content

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Feb 25, 2022

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Description

  1. Separates unit tests from e2e tests - unit tests are now a part of the build pipeline.
  2. Adds utils unit tests to package.json
  3. Add code coverage to tests
  4. Fix e2e test failure detection by upgrading the CLI version. Note, this is only a temporary addition until CLI v1.7 is released. The current custom reference makes the e2e pipeline significantly slow.

Issue reference

Please reference the issue this PR will close #193 and close #197

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • (NA) Code compiles correctly
  • (NA) Created/updated tests
  • (NA) Extended the documentation

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 requested review from a team as code owners February 25, 2022 10:04
@shubham1172 shubham1172 force-pushed the shubham1172/fix-e2e-pipeline-2 branch from ffad383 to 808094e Compare February 25, 2022 10:26
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@e56f31d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 23d68a2 differs from pull request most recent head 3eebeb5. Consider uploading reports for the commit 3eebeb5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage          ?   30.70%           
=========================================
  Files             ?       70           
  Lines             ?     5472           
  Branches          ?      172           
=========================================
  Hits              ?     1680           
  Misses            ?     3758           
  Partials          ?       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56f31d...3eebeb5. Read the comment docs.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 force-pushed the shubham1172/fix-e2e-pipeline-2 branch from 2b5f032 to a475f46 Compare February 25, 2022 11:02
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Copy link
Member Author

Discussions continued from #200

So apparently, environment variables set by node are not allowed in GH actions. To overcome that, we are touching a file and looking for it in CI.

image

/cc @XavierGeerinck

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 changed the title [WIP] Update testing pipeline Update testing pipeline Mar 10, 2022
@shubham1172
Copy link
Member Author

The tests here will start passing once #209 is checked-in.

@shubham1172 shubham1172 force-pushed the shubham1172/fix-e2e-pipeline-2 branch from 23d68a2 to 3eebeb5 Compare March 10, 2022 08:49
@XavierGeerinck XavierGeerinck merged commit 7520670 into dapr:master Mar 10, 2022
@shubham1172 shubham1172 deleted the shubham1172/fix-e2e-pipeline-2 branch March 10, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline passes even though e2e test fails Code coverage reporting
2 participants