Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for TTL and time/interval formats in actor timers/reminders #123

Open
dmitsh opened this issue Nov 23, 2021 · 6 comments
Open
Assignees
Labels
enhancement-runtime-dependency New feature or request due to a runtime feature
Milestone

Comments

@dmitsh
Copy link

dmitsh commented Nov 23, 2021

This feature has been implemented in Dapr runtime: dapr/dapr#2906

It needed to be available via the SDK.

@withinboredom
Copy link
Contributor

This is already implemented in the SDK via #96 code

@dmitsh
Copy link
Author

dmitsh commented Dec 4, 2021

/reopen

@dmitsh
Copy link
Author

dmitsh commented Dec 4, 2021

@withinboredom , from looking at the code, neither timer nor reminder have TTL in their constructor and logic.

@withinboredom
Copy link
Contributor

Maybe I misunderstood the issue. I thought this was already supported via ISO-8601 via the number of repetitions? How is this different? In PHP, we've used ISO-8601 since the beginning since it's built into PHP and the default way to specify a time span. It did some "best guess" when translating to the golang time lib (which doesn't have a concept of days and years (not every day has 24 hours nor every year 365 days).

@dmitsh
Copy link
Author

dmitsh commented Dec 6, 2021

We have extended timer/reminder scheduling functionality in actors by supporting 3 time formats and adding TTL parameter.
The details are here:
https://docs.dapr.io/developing-applications/building-blocks/actors/howto-actors/#actor-timers-and-reminders
https://www.youtube.com/watch?v=aUAgOlTBVjY#t=33m49s

Let me know if that provides sufficient clarification.

@withinboredom
Copy link
Contributor

Ah, I see what you mean! This is pretty cool. I'll add it in the next release!

@withinboredom withinboredom reopened this Dec 7, 2021
@withinboredom withinboredom added this to the 1.3 milestone Dec 19, 2021
@msfussell msfussell added the enhancement-runtime-dependency New feature or request due to a runtime feature label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement-runtime-dependency New feature or request due to a runtime feature
Projects
None yet
Development

No branches or pull requests

3 participants