Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distributed-calculator and pub-sub package-lock #508

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

wcs1only
Copy link
Contributor

@wcs1only wcs1only commented Jan 12, 2022

Signed-off-by: Charlie Stanley charlie.stanley@microsoft.com

Description

Stale package-lock files make npm install calls take longer. The distributed calculator npm install was taking longer than 5 minutes on MacOS autovalidation. Updating should speed us up a bit.

Manual Testing

Since this involves a bunch of dependency changes for the UI frontend, I also manually validated the change:

Pubsub

Screen Shot 2022-01-12 at 3 33 25 PM

Distributed Calc

Screen Shot 2022-01-12 at 3 38 45 PM

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@wcs1only wcs1only force-pushed the update-package-lock branch 2 times, most recently from 6557a44 to 3270657 Compare January 12, 2022 23:10
@wcs1only wcs1only changed the title Update distributed-calculator package-lock Update distributed-calculator and pub-sub package-lock Jan 12, 2022
Signed-off-by: Charlie Stanley <charlie.stanley@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcs1only wcs1only merged commit e8d2b7b into dapr:master Jan 13, 2022
Arashrohani pushed a commit to Arashrohani/quickstarts that referenced this pull request Feb 16, 2022
Signed-off-by: Charlie Stanley <charlie.stanley@microsoft.com>
Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants