Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed hello worlds quickstarts to use http proxying for service inv… #486

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

greenie-msft
Copy link
Contributor

…ocation

Description

Change service invocation in both hello world examples to use http proxy feature

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary

msfussell
msfussell previously approved these changes Dec 2, 2021
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. [ I thought that we could use the APP_ID env var, but that would not work in all scenarios]

…ocation

Signed-off-by: Nick Greenfield nigreenf@microsoft.com
@wcs1only
Copy link
Contributor

MacOS validation failure is a known issue addressed by #508

@wcs1only wcs1only merged commit 30ae34e into dapr:master Jan 13, 2022
Arashrohani pushed a commit to Arashrohani/quickstarts that referenced this pull request Feb 16, 2022
…ocation (dapr#486)

Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
Signed-off-by: Arash Rohani <arash.rohani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants