Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't view some "Hidden" thumbnails #2

Open
bluefiberbread opened this issue Dec 15, 2017 · 18 comments
Open

Can't view some "Hidden" thumbnails #2

bluefiberbread opened this issue Dec 15, 2017 · 18 comments
Labels

Comments

@bluefiberbread
Copy link

bluefiberbread commented Dec 15, 2017

Using Chrome with the latest version of BBB (8.0.2) and it won't expose the hidden thumbnails. Tampermonkey (4.4) is being used too.

https://danbooru.donmai.us/posts?limit=200&page=5&tags=banned_artist
https://i.imgur.com/2MyKpM6.jpg

@Darayavaush
Copy link
Owner

  1. Did you modify the BBB code as specified in the instructions?
  2. Did you ever see a text box about the batch pulling in the top right corner?
  3. Is there a message "Nothing to do, wait for next batch." in the console?

@bluefiberbread
Copy link
Author

Yeah, it breaks/disables BBB too

@Darayavaush
Copy link
Owner

"Breaks"? Do you see the "BBB settings" menu at the top? Could you post the modified BBB source, please?
Also, what about the other two questions?
Also also, I just installed it on Tampermonkey myself and Chrome informed me about a cross-origin request. Did you get this window?

@bluefiberbread
Copy link
Author

No, I don't see BBB settings in the menu after following the instructions, I got the cross-origin request. I did modify the BBB code as specified in the instructions.

https://puu.sh/yHoQg/9c00a66710.jpg
https://puu.sh/yHoRx/84bb2e02dd.jpg

@Darayavaush
Copy link
Owner

You modified the second one incorrectly, inserting the new block before the specified line instead of after it. Since it references an undeclared variable, that's enough to break everything.

@bluefiberbread
Copy link
Author

https://puu.sh/yHDXm/0f333a1b3d.jpg
https://puu.sh/yHDYZ/ed395a3993.jpg

It shows some of the thumbnails (just a few now) but the full picture is still hidden

@Darayavaush
Copy link
Owner

Darayavaush commented Dec 16, 2017

It should be inserted immediately after the specified line, not randomly somewhere below.

@bluefiberbread
Copy link
Author

I reinstalled Tampermonkey and it works fine now but there are some hidden thumbnails. Where can I PM the links to you

@Darayavaush
Copy link
Owner

Darayavaush commented Dec 16, 2017

df6c020dc48b5743a6ec52aa5551c9b9 (or you can simply list the IDs here)

@bluefiberbread
Copy link
Author

bluefiberbread commented Dec 16, 2017

I sent it to df6c020dc48b5743a6ec52aa5551c9b9

@Darayavaush
Copy link
Owner

Yeah, I see what happened there. I'll think about how it can be fixed.

@Darayavaush Darayavaush changed the title Can't view "Hidden" thumbnails Can't view some "Hidden" thumbnails Dec 19, 2017
@bluefiberbread
Copy link
Author

did you come up with a solution

@Darayavaush
Copy link
Owner

Darayavaush commented May 31, 2018

There are several potential solutions, but all of them are going to be a huge PITA to implement and I'm fairly busy. I'll get to it eventually™, don't worry.

@Zanmato27
Copy link

Any updates on this?

@Darayavaush
Copy link
Owner

Ha, exactly one year later. Nice. :D

Unfortunately, eventually™ has not yet arrived, but as a stopgap measure I pushed an update with all currently hidden old posts (3k of them). This should last us the next year. :)

@b1116490
Copy link

Hello, I'm hijacking this thread because I have the same issue as OP before, Have the

Decensooru started. There are 1 items in DB
Nothing to do, wait for next batch.

messages in the console and no thumbnails or pictures even on old art. I am 99.9% sure I did everything correctly. I use tampermonkey by the way.

@Darayavaush
Copy link
Owner

Your issue is completely different, but whatever. I just added an option to do a full refresh. Update the script and look into the footer of any page on Danbooru. Click 'force full refresh' once and tell me what happens.

@b1116490
Copy link

b1116490 commented Jun 19, 2019

My bad, I thought it was the same. Anyway, it works now. Thanks!

There are a few entries without art still but for the most part it seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants