Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mmap-fixed's winapi dependency #32

Open
Vurv78 opened this issue Apr 19, 2022 · 6 comments
Open

Update mmap-fixed's winapi dependency #32

Vurv78 opened this issue Apr 19, 2022 · 6 comments

Comments

@Vurv78
Copy link

Vurv78 commented Apr 19, 2022

I apologize in advance as this isn't an issue with this repository exactly, but you don't have a repo dedicated for this.

The dependency mmap-fixed is doubling my compile time simply because of the dependency on winapi 0.2 (which takes 4x as long to compile in comparison to 0.3), and is now causing warnings from cargo about code that will soon be rejected by Rust..

Would appreciate if the winapi dependency could be updated to 0.3+

@khang06
Copy link

khang06 commented May 8, 2022

since this hasn't been updated for 20 days, i decided to just port it over to winapi 0.3 myself

[patch.crates-io]
mmap-fixed = { git = "https://github.com/khang06/rust-mmap-fixed-fixed.git", rev = "47116f5" }

@ghost
Copy link

ghost commented May 11, 2022

@darfink 😊 Bump, it would be really nice if you can updates the dependencies:

[dependencies]

  • generic-array = "0.14.1" to "0.14.6"
  • lazy_static = "1.2" to "1.4.0"
  • libc = "0.2.45" to "0.2.127"
  • mmap-fixed = "0.1.0" to "0.1.5" (with port to winapi "0.3.9 )
  • region = "2.0.0" to "3.0.0"

[dev-dependencies]

  • matches = "0.1.8" to "0.1.9"

Moreover, I would recommand to switch to the new official windows crate.

Thanks.

@xNxExOx
Copy link

xNxExOx commented Jun 21, 2022

@darfink is this crate still maintained?

@xNxExOx
Copy link

xNxExOx commented Jul 9, 2022

@darfink you forget to push version 0.8.1 which is on https://crates.io/crates/detour to the github?

@Rudxain
Copy link

Rudxain commented Jul 19, 2022

At this rate, I won't be surprised if we need mmap-fixed-fixed-repaired-updated-bumped-plus-ultra-max-super-pro

@philpax
Copy link

philpax commented Aug 6, 2022

For those dropping by, I'm using @lostinspiration's fork with no issues:
detour = {git = "https://github.com/lostinspiration/detour-rs.git"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants