Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event delegation support #36

Closed
shinuza opened this issue May 20, 2013 · 6 comments
Closed

Add event delegation support #36

shinuza opened this issue May 20, 2013 · 6 comments

Comments

@shinuza
Copy link
Contributor

shinuza commented May 20, 2013

iCheck will not forward events when using event delegation, check this for reference:

Regular inputs:

http://codepen.io/anon/pen/dcIoh

iCheck inputs:

http://codepen.io/anon/pen/ktyvG

iCheck needs to forward those events to the underlying input

@drgullin
Copy link
Owner

iCheck doesn't support click event on inputs because of the nested labels support (inputs directly inside labels and labels inside labels).
You may use callbacks and methods instead.

@shinuza
Copy link
Contributor Author

shinuza commented May 20, 2013

This impairs iCheck capabilities of being a drop in replacement for regular inputs

@joangrigorov
Copy link

I support shinuza's comment. We also have much problems with this. We have a lot of plug-ins that use the classic change event and if we update all plugins (which is not a quick job) we end up with plugins depending on iCheck, which is not good.

@kasperisager
Copy link

Any news on this?

@drgullin
Copy link
Owner

Prepared for the next version.

@kasperisager
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants