Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new () should have return type #11

Open
Tracked by #99
kainino0x opened this issue Apr 13, 2021 · 0 comments
Open
Tracked by #99

new () should have return type #11

kainino0x opened this issue Apr 13, 2021 · 0 comments

Comments

@kainino0x
Copy link

kainino0x commented Apr 13, 2021

Currently IDL interfaces with constructors will generate declare vars like:

declare var GPUOutOfMemoryError: {
  prototype: GPUOutOfMemoryError;
  new ();
};

However some compiler settings (such as the ones used in gpuweb/cts) will actually consider new () to return any instead of the apparent usual default GPUOutOfMemoryError (I'm not exactly sure why), causing linter errors. Would be best to write the return type explicitly I think.

declare var GPUOutOfMemoryError: {
  prototype: GPUOutOfMemoryError;
  new (): GPUOutOfMemoryError;
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant