Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RemoteProtocolsChange to detect bitswap protocol #78

Closed
dariusc93 opened this issue Jun 18, 2023 · 0 comments · Fixed by #115
Closed

Use RemoteProtocolsChange to detect bitswap protocol #78

dariusc93 opened this issue Jun 18, 2023 · 0 comments · Fixed by #115
Labels
p:normal Normal Priority refactor

Comments

@dariusc93
Copy link
Owner

In the current implementation, we are injecting the protocol into the bitswap protocol to determine the protocol the peer advertise, if any, however with recent changes to libp2p (0.52 once released), we can use ConnectionEvent::RemoteProtocolsChange in the handler to determine if the peer has the supported protocol.
@dariusc93 dariusc93 added p:low Low Priority refactor labels Jun 18, 2023
@dariusc93 dariusc93 added p:normal Normal Priority and removed p:low Low Priority labels Aug 4, 2023
@dariusc93 dariusc93 mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:normal Normal Priority refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Verify protocol in handler dariusc93/rust-ipfs
1 participant
@dariusc93