Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ header doesn't include require QT types #33

Closed
GoogleCodeExporter opened this issue Apr 5, 2016 · 1 comment
Closed

C++ header doesn't include require QT types #33

GoogleCodeExporter opened this issue Apr 5, 2016 · 1 comment
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

The C++ header file "diff_match_patch.h" doesn't include the QT types it uses, 
which force users of this header to include then in the each file that include 
the header.

IMO will be better to put the required QT includes in "diff_match_patch.h"

The required includes are

#include <QString>
#include <QList>
#include <QMap>
#include <QVariant>

Original issue reported on code.google.com by pepone.o...@gmail.com on 23 Dec 2010 at 9:34
@GoogleCodeExporter
Copy link
Author 

Thanks.  Added.

Will be in the next push (early next week?)

Original comment by neil.fra...@gmail.com on 29 Dec 2010 at 12:00

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter