Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pt-BR.md #11

Merged
merged 4 commits into from
Nov 25, 2019
Merged

Add pt-BR.md #11

merged 4 commits into from
Nov 25, 2019

Conversation

FaelLiberatori
Copy link
Contributor

Add Brazilian Portuguese translation for the help page.

@alexanderby
Copy link
Member

Sorry, didn't notice it.

How do you think, is it applicable to pt-PT? Maybe let's rename to pt.md?

@FaelLiberatori
Copy link
Contributor Author

Sorry, didn't notice it.

How do you think, is it applicable to pt-PT? Maybe let's rename to pt.md?

The difference is pretty much the same as American English vs British English. Some words are different, the accent is different, but we can understand each other with no problem. Ideally, it should have pt-PT and pt-BR, but, as far as we have no pt-PT yet, I see no problem renaming it to pt.md.

Do I rename it or do you rename it?

@alexanderby
Copy link
Member

Great. The app translation for PT and BR is the same either. I think you should do it, so that your name will remain in Dark Reader's git history :)

@FaelLiberatori
Copy link
Contributor Author

FaelLiberatori commented Nov 23, 2019

Done. Edit: @alexanderby just in case you didn't notice it.

@alexanderby alexanderby merged commit 382a43e into darkreader:master Nov 25, 2019
@alexanderby
Copy link
Member

Thank you. Sorry for the delay, I'm receiving too much notifications now. Just published on the website.

I will add a reference to the available translation in the app soon. Now both Chrome and Firefox teams do manual code check for every update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants