Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh_TW.md #9

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Add zh_TW.md #9

merged 2 commits into from
Oct 7, 2019

Conversation

reiscigit
Copy link
Contributor

This is the Traditional Chinese translation (zh-TW) for the Help page.

@alexanderby
Copy link
Member

alexanderby commented Oct 7, 2019

@reiscigit How do you think, would it be helpful for those, who use Chinese Simplified? If it could be useful, could you please rename the file to zh.md? If not, could you please right-click Dark Reader icon, select "Inspect Popup", and run chrome.i18n.getUILanguage() in Console? This will give a proper file name. Most likely it will be zh-TW, without the underscore.

Could you please also share result of navigator.languages?

@alexanderby
Copy link
Member

The reason for this confusion is that Chrome extensions use locale files names with underscores. I've just renamed the sources to use dashes.

@reiscigit
Copy link
Contributor Author

Hi, @alexanderby
Sorry I misspelled the filename. It is better to separate the Simplified and Traditional Chinese. I should add the zh-CN.md for the Help page soon.

i118n

@alexanderby alexanderby merged commit a3ca16f into darkreader:master Oct 7, 2019
@alexanderby
Copy link
Member

Great, thanks, I will publish it soon.

@reiscigit reiscigit deleted the zh-TW branch October 8, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants