Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Properly translate possible-* cases in German #147

Closed
ghost opened this issue Jun 5, 2017 · 5 comments
Closed

Properly translate possible-* cases in German #147

ghost opened this issue Jun 5, 2017 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 5, 2017

I noticed this morning that the German translation was missing the following terms:

  • possible-very-light-precipitation
  • possible-light-precipitation
  • possible-very-light-rain
  • possible-light-rain
  • possible-very-light-sleet
  • possible-light-sleet
  • possible-very-light-snow
  • possible-light-snow

I added a quick hack to correct for this, simply copying the terminology from the related cases (e.g. very-light-precipitation, light-precipitation, etc.). Could somebody who is familiar with German fix these lines such that they indicate that the precipitation only has a chance of occurring?

  "possible-very-light-precipitation": "leichter Niederschlag", // FIXME
  "possible-light-precipitation": "leichter Niederschlag", // FIXME
  "possible-very-light-rain": "Nieselregen", // FIXME
  "possible-light-rain": "leichter Regen", // FIXME
  "possible-very-light-sleet": "leichter Graupelregen", // FIXME
  "possible-light-sleet": "leichter Graupelregen", // FIXME
  "possible-very-light-snow": "leichter Schneefall", // FIXME
  "possible-light-snow": "leichter Schneefall", // FIXME

Based on the possible-thunderstorm term, my guess is that the translation would be the following, but I would appreciate confirmation/correction:

  "possible-very-light-precipitation": "mögliche leichter Niederschlag",
  "possible-light-precipitation": "mögliche leichter Niederschlag",
  "possible-very-light-rain": "mögliche Nieselregen",
  "possible-light-rain": "mögliche leichter Regen",
  "possible-very-light-sleet": "mögliche leichter Graupelregen",
  "possible-light-sleet": "mögliche leichter Graupelregen",
  "possible-very-light-snow": "mögliche leichter Schneefall",
  "possible-light-snow": "mögliche leichter Schneefall",

Thanks!

(Tagging @jacbz @mrkcohen @TheMikeGraz as they previously contributed to this translation.)

@ghost ghost added the bug label Jun 5, 2017
@jacbz
Copy link
Contributor

jacbz commented Jun 5, 2017

In German, you would simply add "möglich" (possible) at the end of the sentence. So for example, "Possible light precipitation [on Friday]" becomes "Leichter Regen [am Freitag] möglich".

Also:

  • very light precipitation has a German term: "Nieselregen"
  • possible-thunderstorm is incorrect, it should be "Gewitter.... möglich" as above

@ghost
Copy link
Author

ghost commented Jun 13, 2017

Does "Nieselregen" refer to all kinds of precipitation, or does it refer specifically to rain (e.g. liquid precipitation)?

@jacbz
Copy link
Contributor

jacbz commented Jun 13, 2017

Nieselregen is defined as light rain where the rain drops are smaller than 0.5 millimetres in diameter.

@ghost
Copy link
Author

ghost commented Jun 13, 2017

Got it, thanks. So we'll want to use that for very-light-rain, but not very-light-precipitation, which might not be liquid. (We use -precipitation when we don't know the type.)

@ghost ghost closed this as completed in #148 Jun 13, 2017
@ghost
Copy link
Author

ghost commented Jun 13, 2017

Merged a fix in. Thanks all!

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant