crop : ensure right params computation on focus out

darktable-org · May 12, 2021 · 210e876 · 210e876
1 parent 15f539a
commit 210e876
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/iop/clipping.c b/src/iop/clipping.c
@@ -1354,7 +1354,7 @@ void gui_focus(struct dt_iop_module_t *self, gboolean in)
       {
         keystone_type_populate(self, FALSE, 0);
       }
-      // weird hack : commit_box use distort_transform routines with gui values to get params
+      // hack : commit_box use distort_transform routines with gui values to get params
       // but this values are accurate only if clipping is the gui_module...
       // so we temporary put back gui_module to clipping and revert once finished
       dt_iop_module_t *old_gui = self->dev->gui_module;

diff --git a/src/iop/crop.c b/src/iop/crop.c
@@ -406,7 +406,13 @@ void gui_focus(struct dt_iop_module_t *self, gboolean in)
     }
     else
     {
+      // hack : commit_box use distort_transform routines with gui values to get params
+      // but this values are accurate only if crop is the gui_module...
+      // so we temporary put back gui_module to crop and revert once finished
+      dt_iop_module_t *old_gui = self->dev->gui_module;
+      self->dev->gui_module = self;
       _commit_box(self, g, p);
+      self->dev->gui_module = old_gui;
       g->clip_max_pipe_hash = 0;
     }
   }