Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send to trash: add an option to delete all files #1082

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

bennygui
Copy link
Contributor

@LebedevRI
Copy link
Member

Adds new string, probably a feature(?) => will have to wait until after 2.0

@bennygui
Copy link
Contributor Author

@LebedevRI I'm letting you decide what is best... but from the thread, the person who reported this said: "As a person, who had to click the button 50+ times I would prefer having
an untranslated string :)"

Anyway... It will probably not affect many users.

@houz
Copy link
Member

houz commented Feb 3, 2016

What about a checkbox "remember the choice" or "don't ask again" (or something like that) which just remembers whatever you click for that job. It would allow deleting them all, but also to just remove all of them from the collection. Or whatever someone wants.

@bennygui
Copy link
Contributor Author

bennygui commented Feb 3, 2016

I'm not sure it's worth putting a lot of effort into: this dialog will almost never pop except if you have weird file permissions or if trashing is disabled on the system or the filesystem.

@TurboGit
Copy link
Member

TurboGit commented Jan 3, 2019

Is that still needed? If so, can this be rebased and retested on current master? Thanks.

Otherwise let me know and I'll close this PR. Thanks.

@rahbek1
Copy link

rahbek1 commented Feb 4, 2019

I would like this improvement.
All my images are located on a NFS mount. Whenever I try to delete an image I get this message: "Trashing on system internal mounts is not supported."

I guess that more people will run into this issue since NFS and CIFS was added to the list of system internal filesystems
https://gitlab.gnome.org/dsd/glib/commit/d1eaf72c001279aa15a2135a0749ef864c8edb42
https://gitlab.gnome.org/dsd/glib/commit/0d69462f146071ee4ad1407f9d9ac56f65c9d485

@TurboGit TurboGit added feature: enhancement current features to improve incomplete pull request needing changes to be merged labels Feb 20, 2019
@TurboGit TurboGit self-assigned this Feb 20, 2019
@TurboGit TurboGit self-requested a review February 20, 2019 09:58
@TurboGit TurboGit added this to the 2.8 milestone Feb 20, 2019
@TurboGit TurboGit merged commit c6d8636 into darktable-org:master Feb 20, 2019
@TurboGit
Copy link
Member

Merged manually fixing the conflicts. Tested and working as expected. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: enhancement current features to improve incomplete pull request needing changes to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants