Port to openjpeg2 new api (2.1+) #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake Warning (dev) at cmake/modules/LibFindMacros.cmake:160 (message): Plural form Glib_LIBRARIES;Glib_LIBRARY found in config options of GIO. This works as before but is now deprecated. Please only use singular forms INCLUDE_DIR and LIBRARY, and update your find scripts for LibFindMacros > 2.0 automatic dependency system (most often you can simply remove the PROCESS variables entirely). Call Stack (most recent call first): cmake/modules/FindGIO.cmake:26 (libfind_process) src/CMakeLists.txt:196 (find_package)
At least in debian, libopenjpeg-dev 1:1.5.2-3.1 installs openjpeg.h not just as /usr/include/openjpeg-1.5/openjpeg.h, but also as /usr/include/openjpeg.h Without NO_DEFAULT_PATH, cmake does not find the right openjpeg.h in /usr/include/openjpeg-2.1/openjpeg.h, and does not set OpenJPEG_INCLUDE_DIR to /usr/include/openjpeg-2.1, but to /usr/include...
| # Include dir | ||
| find_path(OpenJPEG_INCLUDE_DIR | ||
| NAMES openjpeg.h | ||
| PATHS ${OpenJPEG_PKGCONF_INCLUDE_DIRS} |
There was a problem hiding this comment.
That should go into HINTS, not PATHS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dt_imageio_j2k_read_profile()apparently needs to decode whole image. even after going through openjpeg sources, i see no way to replaceparameters.cp_limit_decoding = LIMIT_TO_MAIN_HEADER;Caveat 2: at least in debian,Seems to be fixed by the last commitopenjpeg-1.5installs<openjpeg.h>into/usr/includetoo.I think i have workarounded that, but if
libopenjpeg-devis installed side-by-side with newlibopenjp2-7-dev, there may be issues (works for me right now)...openjp2-2.1api is different (obviously) from old v1.5, do we want to support old `openjpeg-1.5 too? I guess can be done, but will be ugly.As far as i can tell, this is feature complete.
Exporting to {jp2,j2k} works, reading from works, reading ICC works.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826810
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826805