Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locale for aperture filter #16044

Merged
merged 7 commits into from
Jan 7, 2024
Merged

Fix locale for aperture filter #16044

merged 7 commits into from
Jan 7, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Jan 6, 2024

fixes #16031

The locale needs to be switched for the aperture values, similar to the exposure filter.

@zisoft zisoft requested a review from AlicVB January 6, 2024 11:15
@TurboGit TurboGit added this to the 4.6.1 milestone Jan 6, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters difficulty: trivial some changes in a couple of functions release notes: pending labels Jan 6, 2024
parafin
parafin reviewed Jan 6, 2024
View reviewed changes
src/libs/filters/aperture.c Outdated Show resolved Hide resolved
TurboGit
TurboGit reviewed Jan 6, 2024
View reviewed changes
src/common/utility.c Outdated Show resolved Hide resolved
TurboGit
TurboGit approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks!

@TurboGit TurboGit merged commit 2d135a3 into darktable-org:master Jan 7, 2024
4 checks passed
TurboGit pushed a commit that referenced this pull request Jan 7, 2024
@zisoft @TurboGit
Fix locale for aperture filter (#16044)
ce8577d 
* update filter for iso and ratio
@TurboGit
Copy link
Member

TurboGit commented Jan 7, 2024

Squashed and merged in master & 4.6.x branch.

@zisoft zisoft deleted the aperture-locale branch January 7, 2024 08:12
@zisoft
Copy link
Collaborator Author

zisoft commented Jan 7, 2024 •
edited

For the release notes:
Fixed collection aperture filter not working on some locales.

@zisoft zisoft mentioned this pull request Jan 10, 2024
Open
@Pepa-D750 Pepa-D750 mentioned this pull request Jan 16, 2024
Closed
@zisoft zisoft mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parafin parafin parafin left review comments

@TurboGit TurboGit TurboGit approved these changes

@AlicVB AlicVB Awaiting requested review from AlicVB

Assignees
No one assigned
Labels
bugfix pull request fixing a bug difficulty: trivial some changes in a couple of functions priority: medium core features are degraded in a way that is still mostly usable, software stutters
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

The collection selection does not work correctly
3 participants
@zisoft @TurboGit @parafin