Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color balance module : add the ASC CDL mode #1734

Merged
merged 14 commits into from
Oct 16, 2018
Merged

Color balance module : add the ASC CDL mode #1734

merged 14 commits into from
Oct 16, 2018

Commits on Oct 13, 2018

  1. Add comments 

    Add an optimizer for luma values
Use the luma correction in the color neutralization optimization for better accuracy
Refactor some code
Add comments
Disable the luma normalization for RGB sliders in lift/gamma/gain mode to let it as is.
    @aurelienpierre
    aurelienpierre committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    65e5c0d View commit details
    Browse the repository at this point in the history

  2. Add comments 

    Add an optimizer for luma values
Use the luma correction in the color neutralization optimization for better accuracy
Refactor some code
Add comments
Disable the luma normalization for RGB sliders in lift/gamma/gain mode to let it as is.
    @aurelienpierre
    aurelienpierre committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    5eb2b20 View commit details
    Browse the repository at this point in the history

  3. cherry-pick colorspaces_inline_conversions.h

    @aurelienpierre
    aurelienpierre committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    6f6755a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Fix the sliders mode reset when the global color-picker is used

    @aurelienpierre
    aurelienpierre committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    272d80d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/darktable-org/darktable i… 

    …nto color-grading-2
    @aurelienpierre
    aurelienpierre committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    ce0fcc3 View commit details
    Browse the repository at this point in the history

  3. Fix segfaults

    @aurelienpierre
    aurelienpierre committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    43ed77a View commit details
    Browse the repository at this point in the history

  4. Ensure the fulcrum contrast does not take negative inputs

    @aurelienpierre
    aurelienpierre committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    ab6a083 View commit details
    Browse the repository at this point in the history

  5. Use init_pipe and cleanup_pipe functions to alloc & free the priv… 

    …ate data structure cleanly
    @aurelienpierre
    aurelienpierre committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    68ca31e View commit details
    Browse the repository at this point in the history

  6. redraw the color-pickers frames

    @aurelienpierre
    aurelienpierre committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    c9a991e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. include Pascal Obry's patch

    @aurelienpierre
    aurelienpierre committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    dd0415a View commit details
    Browse the repository at this point in the history

  2. Ensure GUI is properly initialized. Explicitely init the private data

    @aurelienpierre
    aurelienpierre committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    a873191 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/darktable-org/darktable i… 

    …nto color-grading-2
    @aurelienpierre
    aurelienpierre committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    6c669df View commit details
    Browse the repository at this point in the history

  4. DEBUG : disable temporarily the faulty lines that cause memory corrup… 

    …tion/segfault
    @aurelienpierre
    aurelienpierre committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    ff7c26b View commit details
    Browse the repository at this point in the history

  5. Fix the segfaults for good by using the proper data structure

    @aurelienpierre
    aurelienpierre committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    594aed6 View commit details
    Browse the repository at this point in the history