Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Exif.OlympusEq.LensType for Olympus FT lenses #449

Merged
merged 1 commit into from
Feb 10, 2014
Merged

Use Exif.OlympusEq.LensType for Olympus FT lenses #449

merged 1 commit into from
Feb 10, 2014

Conversation

jnfingerle
Copy link
Contributor

Previously, lens correction didn't match my lenses. With the current trunk of lensfun and this change, everything looks right. Tested with three Olympus FT, three Olympus MFT und three Lumix MFT lenses.

Fixes Bug #9794

Exif.OlympusEq.LensModel and Exif.Photo.LensModel since it is normally
the most precise data and the string used in (the current svn of)
lensfun.
@boucman boucman merged commit eee6642 into darktable-org:master Feb 10, 2014
@jnfingerle jnfingerle deleted the olympus-ft-lens-recognition branch February 10, 2014 19:19
@ghost
Copy link

ghost commented Oct 19, 2015

So this means since Feb 2014 MFT lens corrections should come out fine? Then I am clearly doing something wrong, my lenses are not corrected, auto correct just does a bit of correction... How can I make it work properly? Or where can I find how to do that?

@jnfingerle
Copy link
Contributor Author

@bertdev Well, yes and no. There've been some hick-ups inbetween, but a current version should work fine, if you've got a current version of lensfun (or: the lensfun database). In other words: I'm on the stable ubuntu packages and everything is fine for me.

Could you give further details on what versions you are on et al.?

(JFTR: I'm only a user that provided a few small patches, I'm not part of the dev team.)

@ghost
Copy link

ghost commented Oct 20, 2015

Hello Jan Niklas Fingerle,

Thank you for your answer. It made me very hopeful. Until I noticed the word [darktable] in this message. I understand that I got lost in the GitHub world, because I was looking for issues with Rawtherapee (which doens't seem to be able to read the lensfun database).

Of course I could install Darktable, but that would mean the computer I share with my wife needs to run on a different OS. Seems a bit you may need some developers' skills to work with Darktable (and I'm just a plain user that could only be able find some bugs, but never deliver any patches...).

Thank you, greetings

Date: Mon, 19 Oct 2015 14:14:14 -0700
From: notifications@github.com
To: darktable@noreply.github.com
CC: baarlezander@hotmail.com
Subject: Re: [darktable] Use Exif.OlympusEq.LensType for Olympus FT lenses (#449)

@bertdev Well, yes and no. There've been some hick-ups inbetween, but a current version should work fine, if you've got a current version of lensfun (or: the lensfun database). In other words: I'm on the stable ubuntu packages and everything is fine for me.

Could you give further details on what versions you are on et al.?

(JFTR: I'm only a user that provided a few small patches, I'm not part of the dev team.)


Reply to this email directly or view it on GitHub.

@jnfingerle
Copy link
Contributor Author

You can alway use a dual boot setup. There are many happy "plain users" of darktable. But, if you try that and need further assistance, I'd recommend the darktable users mailinglist.

@ghost
Copy link

ghost commented Oct 20, 2015

OK, will consider it.

Date: Tue, 20 Oct 2015 02:01:37 -0700
From: notifications@github.com
To: darktable@noreply.github.com
CC: baarlezander@hotmail.com
Subject: Re: [darktable] Use Exif.OlympusEq.LensType for Olympus FT lenses (#449)

You can alway use a dual boot setup. There are many happy "plain users" of darktable. But, if you try that and need further assistance, I'd recommend the darktable users mailinglist.


Reply to this email directly or view it on GitHub.

@LebedevRI LebedevRI modified the milestone: 1.5 Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants