Make the colorpicker & geotagging button labels translatable. #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to control the casing of the button as dt style is to be all lower-case. For #9998.
|
Indeed, good catch! Now fixed. |
TurboGit
added a commit
that referenced
this pull request
Jun 25, 2014
…abels Make the colorpicker & geotagging button labels translatable.
|
Could you bring back the icons please? Or did you leave them out on purpose? |
|
Not sure what you mean. Which icons? I have attached the before/after screenshot, I only have the label casing changed:
|
|
Well, that is not what we saw. |
|
That's the beauty of using GTK: it uses the defaults of your desktop environment. IIRC it can even reorder the buttons (ok, cancel, ...) in dialogs. |
|
And that was only those few buttons with the icons. For uniformity probably better without. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to control the casing of the button as dt style is to be
all lower-case.
For #9998.