Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pentax K-3 II and fix lens model detection for K-3(II) #929

Closed
wants to merge 6 commits into from

Conversation

tomtor
Copy link
Contributor

@tomtor tomtor commented Jun 19, 2015

@pmjdebruijn
Copy link
Member

Thanks. However it's not yet complete. We would still be missing the rather critical adobe_coeffs. They can be extract from a PEF converted to DNG, using Adobe DNG Converter. (see tools/dngmeta.sh).

@tomtor
Copy link
Contributor Author

tomtor commented Jun 19, 2015

OK, thanks for the pointers, did that. The coeffs are identical to the S-3.
In cameras.xml I choose black and white for an ISO 800 PEF. The differences for other ISOs are minimal.

I changed make from Ricoh to Pentax, as was also done for the K-3? I think this is needed
for selecting the default "Pentax-like" for base curve.

@tomtor
Copy link
Contributor Author

tomtor commented Jun 19, 2015

Fixed borders and naming in cameras.xml (similar to existing K-3)

@LebedevRI
Copy link
Member

Something is wrong about this PR WRT rebasing - there shouldn't be e.g. my commits.

@pmjdebruijn
Copy link
Member

Final nitpick, due to historical reasons, more specific names in adobe_coeff should be listed first.

So "Pentax K-3 II" should be above "Pentax K-3", otherwise lossy matching will match Pentax K-3 first, since the matrices are identical it's not a problem in this case. And in master we don't do lossy matching anymore. However we still do to some extent in 1.6.x.

@tomtor
Copy link
Contributor Author

tomtor commented Jun 20, 2015

Ok, fixed in:

#930

@LebedevRI LebedevRI modified the milestone: 1.7 Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants