-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pentax K-3 II and fix lens model detection for K-3(II) #929
Conversation
Thanks. However it's not yet complete. We would still be missing the rather critical adobe_coeffs. They can be extract from a PEF converted to DNG, using Adobe DNG Converter. (see tools/dngmeta.sh). |
This functionality got removed a LONG time ago in a2fdac3.
…ue_ptr Same as with imageio_rawspeed: AFAIK apple does not support it, so use #ifdef
OK, thanks for the pointers, did that. The coeffs are identical to the S-3. I changed make from Ricoh to Pentax, as was also done for the K-3? I think this is needed |
Fixed borders and naming in cameras.xml (similar to existing K-3) |
Something is wrong about this PR WRT rebasing - there shouldn't be e.g. my commits. |
Final nitpick, due to historical reasons, more specific names in adobe_coeff should be listed first. So "Pentax K-3 II" should be above "Pentax K-3", otherwise lossy matching will match Pentax K-3 first, since the matrices are identical it's not a problem in this case. And in master we don't do lossy matching anymore. However we still do to some extent in 1.6.x. |
Ok, fixed in: |
See also http://redmine.darktable.org/issues/9897