-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted #17
Comments
Downgrading to 0.0.3 helps, but in further releases this should be fixed |
Confirming issue on my side as well. Sub dependency of |
Does anyone know what's causing this? Since the repo looks abandoned, I'd like to at least create a fork. |
Yeah, I haven't had time to maintain this lately. I'm open to pull requests or anyone else who'd like to help maintain it, though. |
On second thought, I decided to make a little bit of time this morning. I've updated the dependencies and moved some other things around; would you be able to check whether this helps you, or provide a trivial test case that I can validate? |
Hey @darrylhodgins, thanks for jumping in to address this. The new version |
I'm not sure if I'd call it "jumping"; I've been ignoring this project for a while and I forgot that I actually made it to be useful. 😃 Thanks for confirming. I'll close this issue for now. |
Well from my point of view it was a jump in considering I only found the library this weekend 😄 (Also a friendly reminder that the issue is still open!) |
Yeah, I know… I was on the GitHub app this morning and it doesn't have the "Close" button for some reason :D |
angular 8.2.3
typescript 3.5.3
The text was updated successfully, but these errors were encountered: