Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp_normalize_timestamps() can produce negative timestamps in log() #81

Closed
shanedsnyder opened this issue May 13, 2021 · 1 comment
Closed

Comments

@shanedsnyder
Copy link
Contributor

In GitLab by @shanedsnyder on Sep 24, 2015, 16:26

The cp_normalize_timestamps() function was added recently in trunk to normalize all timestamps in the log relative to MPI_Init() time. It doesn't check to see if a timestamp was unused, though, in which case subtracting the offset from 0 produces a negative value.

This function should be fixed to avoid touching 0 values, and maybe also add a check after that to make sure that normalized values are positive.

@shanedsnyder
Copy link
Contributor Author

In GitLab by @shanedsnyder on Sep 24, 2015, 16:26

Fixed in trunk; only deduct init time from timestamps if timestamp is greater than init time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant