This repository has been archived by the owner on Aug 28, 2020. It is now read-only.
Support MFC-J430W, fix many bugs, smarter page post-processing #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Submodules not initialized (#5): $ make make: *** No rule to make target 'ber/ber.c', needed by 'all'. Stop. 2) connection.c: In function ‘brother_conn_poll’: connection.c:179:25: error: ISO C forbids empty initializer braces [-Werror=pedantic] struct pollfd pfd = {}; 3) device_handler.c: In function ‘device_handler_add_device’: device_handler.c:180:9: error: ‘dev’ may be used uninitialized in this function [-Werror=maybe-uninitialized] free(dev); ^~~~~~~~~
rumpeltux
changed the title
Open
chickenandpork
added a commit
to chickenandpork/brother-scand
that referenced
this pull request
Jul 29, 2020
…_64-apple-darwin19.5.0
* minimal customization of stock Apple:
* install XCode from Apple App Store (XCode 11.6 onto MacOS-10.15.6 "Catalina")
* clone the repo per the README (see updated "--recurse-submodules")
* build warning-free per the README
NOTE: I'm not a fam of cmake-ing the world, my personal experience hasn't lead to great cmake support experiences, I'd rather bazelify-the-world personally or drop back to autotools for most compatibility :) For this reason, I see @rumpeltux's darsto#6 but would prefer autotools or bazel to cmake so I've cut a smaller PR to simply update this repo.
Apple's Clang-11.0.3 is:
```
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.3 (clang-1103.0.32.62)
Target: x86_64-apple-darwin19.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
chickenandpork
added a commit
to chickenandpork/brother-scand
that referenced
this pull request
Jul 29, 2020
…_64-apple-darwin19.5.0
* minimal customization of stock Apple:
* install XCode from Apple App Store (XCode 11.6 onto MacOS-10.15.6 "Catalina")
* clone the repo per the README (see updated "--recurse-submodules")
* build warning-free per the README
NOTE: I'm not a fan of cmake-ing the world, my personal experience hasn't lead to great cmake support experiences, I'd rather bazelify-the-world personally or drop back to autotools for most compatibility :) For this reason, I see @rumpeltux's darsto#6 but would prefer autotools or bazel to cmake so I've cut a smaller PR to simply update this repo.
Apple's Clang-11.0.3 is:
```
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.3 (clang-1103.0.32.62)
Target: x86_64-apple-darwin19.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
after observing that the brother HL-L2380DW returns 40000 (0x9c40) in response to a status query, accepting that as a valid response lets brother-scand work nicely with this model as well. Documented HL-L2380DW as working in Readme.MD
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodules not initialized (Sources problem #5):
$ make
make: *** No rule to make target 'ber/ber.c', needed by 'all'. Stop.
connection.c: In function ‘brother_conn_poll’:
connection.c:179:25: error: ISO C forbids empty initializer braces [-Werror=pedantic]
struct pollfd pfd = {};
device_handler.c: In function ‘device_handler_add_device’:
device_handler.c:180:9: error: ‘dev’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
free(dev);
^~~~~~~~~