This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
Patches for atom 1.18 #1130
Merged
Patches for atom 1.18 #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
Jul 27, 2017
lib/impl/tooltip.dart
Outdated
| @@ -116,19 +131,24 @@ class TooltipElement extends CoreElement { | |||
| : super('div', classes: 'hover-tooltip') { | |||
| id = 'hover-tooltip'; | |||
|
|
|||
| print(position); | |||
| @@ -26,9 +26,9 @@ | |||
| "^1.0.0": "consumeToolbar" | |||
| } | |||
| }, | |||
| "linter-plus-self": { | |||
| "linter-indie": { | |||
There was a problem hiding this comment.
Do we need to update the required-packages list above as well?
There was a problem hiding this comment.
Depends on whether whatever is consuming the required-packages key supports version numbers as that service is only available with linter v2.
|
I landed the atom.dart plugin, so the travis build job now finishes cleanly. |
|
Oh damn... like I said I'm new to git, i thought the pull request would
use a snapshot copy... i am not done with reviving the tootips yet.
Should i try to uncommit those changes?
…On Thu, Jul 27, 2017 at 5:03 PM Devon Carew ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for the PR! Much appreciated.
I see you added some additional commits - is this PR still in progress?
------------------------------
In lib/impl/tooltip.dart
<#1130 (comment)>:
> @@ -116,19 +131,24 @@ class TooltipElement extends CoreElement {
: super('div', classes: 'hover-tooltip') {
id = 'hover-tooltip';
+ print(position);
We should remove this.
------------------------------
In package.json
<#1130 (comment)>:
> @@ -26,9 +26,9 @@
"^1.0.0": "consumeToolbar"
}
},
- "linter-plus-self": {
+ "linter-indie": {
Do we need to update the required-packages list above as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1130 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdDFw6iSkR7Qw_GKJq4J4qhnmy818m0Rks5sSKasgaJpZM4Ojrrg>
.
|
I would either revert those changes and update the PR, or keeping working and I can re-review when you're done. You'll have a bit of a git dance to do, so the 2nd option would likely be easier for you (given that you're new to git. I'm happy with whichever way you'd prefer - |
|
Thanks, I'll take option two :). It shouldn't be too long, probably some
time tomorrow.
…On Thu, Jul 27, 2017 at 6:51 PM Devon Carew ***@***.***> wrote:
Should i try to uncommit those changes?
I would either revert those changes and update the PR, or keeping working
and I can re-review when you're done. You'll have a bit of a git dance to
do, so the 2nd option would likely be easier for you (given that you're new
to git. Happy either way :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1130 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdDFw5ODkepesE2Nn-JPCqby3uYlvTsFks5sSMAZgaJpZM4Ojrrg>
.
|
Moved to stream listeners. Changed tooltip to avoid updating if mouse is over same range.
|
A Better summary of this PR (which is now ready for review, sorry):
|
|
Awesome! Thanks much, landing. |
This was referenced Jul 30, 2017
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed startup for atom 1.18
Fixed pub calls
Fixed linter/squiggles