Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub run build_runner test runs tests even if build has SEVERE errors #911

Closed
chalin opened this issue Jan 26, 2018 · 1 comment
Closed

Comments

@chalin
Copy link
Contributor

chalin commented Jan 26, 2018

I'm not sure if this is related to #910, but pub run build_runner test runs tests even if build has SEVERE errors. I don't think any attempt should be made to run tests if there are build errors.

This should even hold true when repeated attempts are made to run tests. I.e., if you start with a clean project repo, then execute pub run build_runner test and there are build errors then tests should not run.

But also, if I rerun pub run build_runner test (and no source files have changed), the test runner should know that the build failed and refuse to run tests (IMHO).

cc @kwalrath

@jakemac53
Copy link
Contributor

Merging with #910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants