Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need an analyzer version published for 2.11 dev releases #43550

Closed
jakemac53 opened this issue Sep 25, 2020 · 4 comments
Closed

Need an analyzer version published for 2.11 dev releases #43550

jakemac53 opened this issue Sep 25, 2020 · 4 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@jakemac53
Copy link
Contributor

jakemac53 commented Sep 25, 2020 •
edited

Now that we have a 2.11 dev sdk we need an analyzer that supports that language version.

See https://travis-ci.org/github/dart-lang/build/jobs/730147024#L413 - nothing is broken other than our tests, but users will start seeing this warning on the 2.11 dev sdk.
@jakemac53 jakemac53 added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Sep 25, 2020
@jakemac53
Copy link
Contributor Author

This also does seem like something which will happen on each sdk version bump, so open to suggestions for how/if we should change our validation etc.

@bwilkerson
Copy link
Member

@devoncarew

@jakemac53
Copy link
Contributor Author

jakemac53 commented Sep 25, 2020 •
edited

Skipping the test in build_resolvers for now, and will restore it once we have something published. actually just running tests on 2.10 dev for now.

We also don't currently allow enabling of experiments if the ExperimentStatus.currentVersion doesn't exactly match the current sdk version, I am updating that to only require that the sdk version is not greater than that version.

This does mean that experiments are not usable in build_runner right now though since the analyzer version is currently behind the sdk version, but I think the only sensible thing we can do is keep that as a failure.

See dart-lang/build#2840.

@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/164600

dart-bot pushed a commit that referenced this issue Sep 25, 2020
@scheglov
Prepare to publish analyzer 0.40.3 and _fe_analyzer_shared 10.0.0.
b53d016 
Bug: #43550
Change-Id: I555a958c14eb435ab6a8522e89cd90dd851da2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scheglov @jakemac53 @bwilkerson