Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart 2.0 will add first= and last= to lists. #130

Closed
lrhn opened this issue Jan 5, 2018 · 4 comments
Closed

Dart 2.0 will add first= and last= to lists. #130

lrhn opened this issue Jan 5, 2018 · 4 comments
Assignees
@sgrekhov

Comments

@lrhn
Copy link
Member

lrhn commented Jan 5, 2018

Currently, the tests:

LibTest/typed_data/Float32List/first_A01_t02
LibTest/typed_data/Float32List/last_A01_t02
LibTest/typed_data/Float32x4List/first_A01_t02
LibTest/typed_data/Float32x4List/last_A01_t02
LibTest/typed_data/Float64List/first_A01_t02
LibTest/typed_data/Float64List/last_A01_t02
LibTest/typed_data/Int16List/first_A01_t02
LibTest/typed_data/Int16List/last_A01_t02
LibTest/typed_data/Int32List/first_A01_t02
LibTest/typed_data/Int32List/last_A01_t02
LibTest/typed_data/Int64List/first_A01_t02
LibTest/typed_data/Int64List/last_A01_t02
LibTest/typed_data/Int8List/first_A01_t02
LibTest/typed_data/Int8List/last_A01_t02
LibTest/typed_data/Uint16List/first_A01_t02
LibTest/typed_data/Uint16List/last_A01_t02
LibTest/typed_data/Uint32List/first_A01_t02
LibTest/typed_data/Uint32List/last_A01_t02
LibTest/typed_data/Uint64List/first_A01_t02
LibTest/typed_data/Uint64List/last_A01_t02
LibTest/typed_data/Uint8ClampedList/first_A01_t02
LibTest/typed_data/Uint8ClampedList/last_A01_t02
LibTest/typed_data/Uint8List/first_A01_t02
LibTest/typed_data/Uint8List/last_A01_t02

assume that either first or last of a typed data list is not assignable.
@sgrekhov sgrekhov self-assigned this Jan 9, 2018
sgrekhov pushed a commit that referenced this issue Jan 9, 2018
Fix for issue #130. typed_data/...List tests rewritten assuming that …
c4ffc30 
…the Lists now have `first=` and `last=` setters
@sgrekhov
Copy link
Contributor

sgrekhov commented Jan 9, 2018

Fixed in a strong_mode branch (which is intended for Dart 2.0)

@sgrekhov sgrekhov closed this as completed Jan 9, 2018
@lrhn
Copy link
Member Author

lrhn commented Jan 24, 2018

Also, the Float32x4List tests have a type error - they try to assign the number zero to something of type Float32x4.

@sgrekhov sgrekhov reopened this Jan 24, 2018
@sgrekhov
Copy link
Contributor

@lrhn, which one? I'm unable to find any.

@lrhn
Copy link
Member Author

lrhn commented Jan 31, 2018

I was looking at the current version in the Dart SDK and your master branch. I can see you have already fixed it on the strong mode branch, so sorry for the false alert.
(It was doing typedList.first = 0; which would keep being a compile-time error in strong mode even if first has a setteR).

@sgrekhov sgrekhov closed this as completed Feb 5, 2018
sgrekhov pushed a commit that referenced this issue Feb 14, 2022
#130. Roll failure fixed
99258da
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 17, 2022
@athomas
[co19] Roll co19 to 74ba459aecc908d5db91531f020a3f74e9aa1b4d
69f433b 
2022-03-16 eernst@google.com Fixes needed based on roll f5124538 (dart-lang/co19#1323)
2022-03-14 sgrekhov@unipro.ru Fixes dart-lang/co19#1310. Add language version 2.16 (dart-lang/co19#1314)
2022-03-10 519320+chloestefantsova@users.noreply.github.com Correct an enhanced-enum test to alow setters named values (dart-lang/co19#1312)
2022-02-25 sgrekhov@unipro.ru dart-lang/co19#993. Added tests for Abi class
2022-02-25 sgrekhov@unipro.ru dart-lang/co19#1258. Added test for a generic enum which does have a regular-bounded instantiate-to-bounds result
2022-02-24 sgrekhov@unipro.ru Fixes dart-lang/co19#1308. Make `UriData` tests case-insensitive
2022-02-24 sgrekhov@unipro.ru dart-lang/co19#1258. Not regular-bounded enum test added
2022-02-21 irina.arkhipets@gmail.com Merge remote-tracking branch 'remotes/origin/weak-reference-fix'
2022-02-21 sgrekhov@unipro.ru Revert accidental commits
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception
2022-02-21 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator
2022-02-20 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum
2022-02-19 sgrekhov@unipro.ru dart-lang/co19#1260. Fixed tests that check attachment of the same object to finalizer several times
2022-02-18 irina.arkhipets@gmail.com dart-lang/co19#1260: Weak reference tests updated.
2022-02-18 sgrekhov@unipro.ru dart-lang/co19#1258. More implementing enums tests added
2022-02-17 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48412. Different issues fixed in Finalizer tests
2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer test improved
2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Minor code enhancement
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Typo fixed
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Fix attach to finalizer tests
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer tests fixed and refactored
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Another WeakReference tests added
2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated.
2022-02-15 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48391. Use function with 'no-inline' to create a WeakReference and to lost link to its target
2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated.
2022-02-14 sgrekhov@unipro.ru dart-lang/co19#130. Roll failure fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Icc2bea05df29e00b671b2843af7c3c55fa45da35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237581
Reviewed-by: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @lrhn