-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some cascading errors aren't reported by the CFE anymore and should be removed from tests #1305
Comments
sgrekhov
pushed a commit
that referenced
this issue
Feb 21, 2022
sgrekhov
pushed a commit
that referenced
this issue
Feb 21, 2022
sgrekhov
pushed a commit
that referenced
this issue
Feb 21, 2022
Fixed in both |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Mar 17, 2022
2022-03-16 eernst@google.com Fixes needed based on roll f5124538 (dart-lang/co19#1323) 2022-03-14 sgrekhov@unipro.ru Fixes dart-lang/co19#1310. Add language version 2.16 (dart-lang/co19#1314) 2022-03-10 519320+chloestefantsova@users.noreply.github.com Correct an enhanced-enum test to alow setters named values (dart-lang/co19#1312) 2022-02-25 sgrekhov@unipro.ru dart-lang/co19#993. Added tests for Abi class 2022-02-25 sgrekhov@unipro.ru dart-lang/co19#1258. Added test for a generic enum which does have a regular-bounded instantiate-to-bounds result 2022-02-24 sgrekhov@unipro.ru Fixes dart-lang/co19#1308. Make `UriData` tests case-insensitive 2022-02-24 sgrekhov@unipro.ru dart-lang/co19#1258. Not regular-bounded enum test added 2022-02-21 irina.arkhipets@gmail.com Merge remote-tracking branch 'remotes/origin/weak-reference-fix' 2022-02-21 sgrekhov@unipro.ru Revert accidental commits 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception 2022-02-21 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator 2022-02-20 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum 2022-02-19 sgrekhov@unipro.ru dart-lang/co19#1260. Fixed tests that check attachment of the same object to finalizer several times 2022-02-18 irina.arkhipets@gmail.com dart-lang/co19#1260: Weak reference tests updated. 2022-02-18 sgrekhov@unipro.ru dart-lang/co19#1258. More implementing enums tests added 2022-02-17 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48412. Different issues fixed in Finalizer tests 2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer test improved 2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Minor code enhancement 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Typo fixed 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Fix attach to finalizer tests 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer tests fixed and refactored 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Another WeakReference tests added 2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated. 2022-02-15 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48391. Use function with 'no-inline' to create a WeakReference and to lost link to its target 2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated. 2022-02-14 sgrekhov@unipro.ru dart-lang/co19#130. Roll failure fixed Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: Icc2bea05df29e00b671b2843af7c3c55fa45da35 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237581 Reviewed-by: William Hesse <whesse@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Mar 28, 2022
2022-03-23 srawlins@google.com Replace InternetAddressType.ANY with InternetAddressType.any (dart-lang/co19#1326) 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-11 irina.arkhipets@gmail.com Fixes dart-lang/co19#1300: Corrected tests according to the recent changes in CFE. 2022-01-31 sgrekhov@unipro.ru dart-lang/co19#1281. Expected error location updated 2021-12-13 irina.arkhipets@gmail.com Issue dart-lang/co19#1094: minor improvement for Utils/test_mode_check 2021-12-06 irina.arkhipets@gmail.com Issue dart-lang/co19#1094: Runtime executable mode checks moved to Utils/Expect, Language/Libraries_and_Scripts/Scripts, LibTest/io/Process tests corrected. 2021-11-29 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: Language/Reference/Lexical_Rules/Reserved_Words/final_t06 test corrected according to the current dart 2.9 behavior. 2021-11-25 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: Language/Reference/Lexical_Rules/Reserved_Words/final_t06.dart updated, Language/Variables/Evaluation_of_Implicit_Variable_Getters comments updated, missing Issue tags added. 2021-11-24 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: LibTest/typed_data tests updated according to the changes in master. 2021-11-24 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: LibTest/io/Link test updated: changes from master moved to pre-nnbd. 2021-11-24 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: LibTest/io/Link tests updated: changes from master moved to pre-nnbd, missung Issue tags added, comments added. 2021-11-24 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: LibTest/io/Process/killPid_* tests updated. 2021-11-24 irina.arkhipets@gmail.com More fix for dart-lang/co19#1094: LibTest/io/Process tests updated to check process exit code correctly, new test added. Change-Id: I2f2a857d71b17b568534921ae7edfb517290d9ea Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239064 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The CLs https://dart-review.googlesource.com/c/sdk/+/233363 and https://dart-review.googlesource.com/c/sdk/+/233382 prevent certain errors from being reported in some of the cases where that was caused by a recovery from another error. The error reporting in those cases is now in agreement to Analyzer. The following tests should be updated to reflect the changes.
Language/Functions/Formal_Parameters/Optional_Formals/syntax_t12.dart
This test should be updated in branches
master
andpre-nnbd
. The following expectations of an error from the CFE should be removed.co19/Language/Functions/Formal_Parameters/Optional_Formals/syntax_t12.dart
Lines 22 to 24 in 42d638c
co19/Language/Functions/Formal_Parameters/Optional_Formals/syntax_t12.dart
Lines 25 to 27 in 1b9f593
Language/Functions/Formal_Parameters/Optional_Formals/syntax_t13.dart
This test should be updated in branch
pre-nnbd
. The following expectation of an error from the CFE should be removed.co19/Language/Functions/Formal_Parameters/Optional_Formals/syntax_t13.dart
Lines 26 to 27 in 1b9f593
Language/Functions/Formal_Parameters/Required_Formals/syntax_t03.dart
This test should be updated in branches
master
andpre-nnbd
. The following expectations of an error from the CFE should be removed.co19/Language/Functions/Formal_Parameters/Required_Formals/syntax_t03.dart
Lines 35 to 37 in 42d638c
co19/Language/Functions/Formal_Parameters/Required_Formals/syntax_t03.dart
Lines 39 to 41 in 1b9f593
Language/Enums/syntax_t08.dart
This test should be updated in branches
master
andpre-nnbd
. The following expectations of an error from the CFE should be removed.co19/Language/Enums/syntax_t08.dart
Lines 22 to 24 in 42d638c
co19/Language/Enums/syntax_t08.dart
Lines 22 to 24 in 1b9f593
Language/Enums/syntax_t09.dart
This test should be updated in branches
master
andpre-nnbd
. The following expectations of an error from the CFE should be removed.co19/Language/Enums/syntax_t09.dart
Lines 21 to 23 in 42d638c
co19/Language/Enums/syntax_t09.dart
Lines 22 to 24 in 1b9f593
The text was updated successfully, but these errors were encountered: