Some tests need language versions for the 2.19 release #1310
Comments
sgrekhov
pushed a commit
to sgrekhov/co19
that referenced
this issue
Mar 14, 2022
|
Please see #1314 |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Mar 17, 2022
2022-03-16 eernst@google.com Fixes needed based on roll f5124538 (dart-lang/co19#1323) 2022-03-14 sgrekhov@unipro.ru Fixes dart-lang/co19#1310. Add language version 2.16 (dart-lang/co19#1314) 2022-03-10 519320+chloestefantsova@users.noreply.github.com Correct an enhanced-enum test to alow setters named values (dart-lang/co19#1312) 2022-02-25 sgrekhov@unipro.ru dart-lang/co19#993. Added tests for Abi class 2022-02-25 sgrekhov@unipro.ru dart-lang/co19#1258. Added test for a generic enum which does have a regular-bounded instantiate-to-bounds result 2022-02-24 sgrekhov@unipro.ru Fixes dart-lang/co19#1308. Make `UriData` tests case-insensitive 2022-02-24 sgrekhov@unipro.ru dart-lang/co19#1258. Not regular-bounded enum test added 2022-02-21 irina.arkhipets@gmail.com Merge remote-tracking branch 'remotes/origin/weak-reference-fix' 2022-02-21 sgrekhov@unipro.ru Revert accidental commits 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception 2022-02-21 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception 2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator 2022-02-20 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum 2022-02-19 sgrekhov@unipro.ru dart-lang/co19#1260. Fixed tests that check attachment of the same object to finalizer several times 2022-02-18 irina.arkhipets@gmail.com dart-lang/co19#1260: Weak reference tests updated. 2022-02-18 sgrekhov@unipro.ru dart-lang/co19#1258. More implementing enums tests added 2022-02-17 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48412. Different issues fixed in Finalizer tests 2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer test improved 2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Minor code enhancement 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Typo fixed 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Fix attach to finalizer tests 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer tests fixed and refactored 2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Another WeakReference tests added 2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated. 2022-02-15 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48391. Use function with 'no-inline' to create a WeakReference and to lost link to its target 2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated. 2022-02-14 sgrekhov@unipro.ru dart-lang/co19#130. Roll failure fixed Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: Icc2bea05df29e00b671b2843af7c3c55fa45da35 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237581 Reviewed-by: William Hesse <whesse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following tests have begun failing with the flag flip for the named parameters anywhere feature, since they test code that is no longer erroneous post Dart 2.17:
I am approving the failures for now, but we should follow up by adding 2.16 language version markers to these tests.
cc @lrhn @eernstg @athomas
The text was updated successfully, but these errors were encountered: