Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion between named and positional fields in a records test #1488

Closed
chloestefantsova opened this issue Oct 6, 2022 · 0 comments
Closed

Confusion between named and positional fields in a records test #1488

chloestefantsova opened this issue Oct 6, 2022 · 0 comments
Assignees
@sgrekhov
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@chloestefantsova
Copy link
Contributor

It seems that the named and the positional fields are confused in some lines in https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Records/type_promotion_A01_t02.dart.

  1. In line 32 it should say ({int? n, String o}) instead of (int? n, String o).
  2. In line 44 it should say (s: "Lily was here",) instead of ("Lily was here",).
@sgrekhov sgrekhov self-assigned this Oct 6, 2022
@sgrekhov sgrekhov added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Oct 6, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 6, 2022
@sgrekhov
Fixes dart-lang#1488. Use correct record types
0a72204
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 24, 2022
@sgrekhov @athomas
[co19] Roll co19 to 0c2b4c60350c7e3239913b8186770e5203c18eb2
cd75b47 
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1511. [Records] Remove `records` experimental flag from legacy libraries (dart-lang/co19#1512)
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1477. [Records] Type inference tests updated (dart-lang/co19#1500)
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1505. [Records] Added tests for dynamic access to record fields (dart-lang/co19#1507)
2022-10-19 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Interaction with legacy tests added (dart-lang/co19#1502)
2022-10-19 sgrekhov22@gmail.com dart-lang/co19#195. Typos fixed (dart-lang/co19#1508)
2022-10-19 sgrekhov22@gmail.com dart-lang/co19#993. [ffi] nullptr test added (dart-lang/co19#1506)
2022-10-14 asashour@yahoo.com Fix typos (dart-lang/co19#1504)
2022-10-12 sgrekhov22@gmail.com Fixes dart-lang/co19#1427. Expando tests added (dart-lang/co19#1479)
2022-10-12 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] More members tests added (dart-lang/co19#1501)
2022-10-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.0.2 to 3.1.0 (dart-lang/co19#1499)
2022-10-11 sgrekhov22@gmail.com dart-lang/co19#1400. [Views] Syntax tests added (dart-lang/co19#1498)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1491. Use correct record type in 'as' expression (dart-lang/co19#1497)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1489. Don't use '?' in expressions (dart-lang/co19#1495)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1488. Use correct record types (dart-lang/co19#1493)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1490. Missing parameters names added (dart-lang/co19#1496)

Change-Id: I6d26701ee14a0c7820e3c3094d7d850c0f914028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265087
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @sgrekhov