#1400. [Views] Syntax tests added #1498
Conversation
There was a problem hiding this comment.
Please include constant constructors as well. They are not mentioned, and we're discussing possible syntaxes for specifying that the primary constructor is constant, but it would be nice to ensure that testing for them is already included such that we don't forget.
Looks good! A few things are marked as errors, but are actually allowed, and I marked a couple of typos, too.
|
|
||
| library views_lib; | ||
|
|
||
| int x = 42; |
There was a problem hiding this comment.
Please add the newline at the end, you never know which (UNIX-ish) tools will be surprised when it's missing.
| /// The token `view` is made a built-in identifier. | ||
| /// | ||
| /// @description Checks that it is a compile-time error to declare a function | ||
| /// named `view` |
There was a problem hiding this comment.
No, that would actually not be an error. I've specified that view is a built-in identifier, which means that it would be an error to declare a type with that name, but other things (a function, a local variable, etc, anything-not-an-type) would be ok.
| /// The token `view` is made a built-in identifier. | ||
| /// | ||
| /// @description Checks that it is a compile-time error to declare a constant | ||
| /// named `view` |
|
|
||
| // SharedOptions=--enable-experiment=extension-types | ||
|
|
||
| import "views_lib.dart" as view; |
There was a problem hiding this comment.
Yes! A prefix is not a type, but it is indeed included among the things that can't have a name which is a built-in identifier. I forgot to mention that above.
| /// @description Checks that if a view declaration named View that does not | ||
| /// include a <viewPrimaryConstructor>, the name of the representation is the | ||
| /// name id of the unique final instance variable that it declares, and the type | ||
| /// of the representation is the declared type of id |
There was a problem hiding this comment.
Yes, in this case the syntax is different, but the representation name/type should be tested in the same way, statically and dynamically.
| } | ||
|
|
||
| view class View2(int id) { | ||
| void set id(int val) {} |
There was a problem hiding this comment.
The name of this setter is actually id=, so that's not an error.
Co-authored-by: Erik Ernst <eernst@google.com>
|
I added const constructors tests and did a fixes according to the other notes. Please rereview |
| Expect.isTrue(v1 is int); | ||
| Expect.isTrue(v2 is num); | ||
| Expect.isTrue(v2 is double); | ||
| } |
There was a problem hiding this comment.
One more missing newline at the end.
| Expect.isTrue(v1 is int); | ||
| Expect.isTrue(v2 is num); | ||
| Expect.isTrue(v2 is double); | ||
| } |
|
Thanx. Fixed. Please rereview |
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1511. [Records] Remove `records` experimental flag from legacy libraries (dart-lang/co19#1512) 2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1477. [Records] Type inference tests updated (dart-lang/co19#1500) 2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1505. [Records] Added tests for dynamic access to record fields (dart-lang/co19#1507) 2022-10-19 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Interaction with legacy tests added (dart-lang/co19#1502) 2022-10-19 sgrekhov22@gmail.com dart-lang/co19#195. Typos fixed (dart-lang/co19#1508) 2022-10-19 sgrekhov22@gmail.com dart-lang/co19#993. [ffi] nullptr test added (dart-lang/co19#1506) 2022-10-14 asashour@yahoo.com Fix typos (dart-lang/co19#1504) 2022-10-12 sgrekhov22@gmail.com Fixes dart-lang/co19#1427. Expando tests added (dart-lang/co19#1479) 2022-10-12 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] More members tests added (dart-lang/co19#1501) 2022-10-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.0.2 to 3.1.0 (dart-lang/co19#1499) 2022-10-11 sgrekhov22@gmail.com dart-lang/co19#1400. [Views] Syntax tests added (dart-lang/co19#1498) 2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1491. Use correct record type in 'as' expression (dart-lang/co19#1497) 2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1489. Don't use '?' in expressions (dart-lang/co19#1495) 2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1488. Use correct record types (dart-lang/co19#1493) 2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1490. Missing parameters names added (dart-lang/co19#1496) Change-Id: I6d26701ee14a0c7820e3c3094d7d850c0f914028 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265087 Reviewed-by: Alexander Thomas <athom@google.com>
No description provided.