Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t0* needs update #2373

Closed
johnniwinther opened this issue Nov 15, 2023 · 2 comments
Closed

LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t0* needs update #2373

johnniwinther opened this issue Nov 15, 2023 · 2 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@johnniwinther
Copy link
Member

The test LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t06 needs to be update wrt to CFE error expectations. An error is emitted on both conflicting members.

LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t01 will also need a similar update when https://dart-review.googlesource.com/c/sdk/+/336400 has landed
@sgrekhov sgrekhov self-assigned this Nov 15, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 15, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 15, 2023
@sgrekhov
Fixes dart-lang#2373. Expect additional errors in CFE for member conf…
c6f7cbd 
…licts tests
@johnniwinther
Copy link
Member Author

I just found that LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t05 also need a similar update.

@sgrekhov
Copy link
Contributor

LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t05 added to #2375

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 17, 2023
@sgrekhov
[co19] Roll co19 to 460758bf4c298812d47b24f7e5040c75088c3ebf
55a2b1c 
2023-11-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2381. Fix roll failures (dart-lang/co19#2382)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2379. Update expected error position for CFE (dart-lang/co19#2380)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2377. Add missing Float32x4List.setAll_A04_t01 test (dart-lang/co19#2378)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2373. Expect additional errors in CFE for member conflicts tests (dart-lang/co19#2375)
2023-11-16 sgrekhov22@gmail.com dart-lang/co19#2359. Fix existing extension types tests according to the new nullability rules (dart-lang/co19#2372)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix nullability in dynamic_semantics_member_invocation_A03_t02.dart (dart-lang/co19#2368)
2023-11-16 sgrekhov22@gmail.com dart-lang/co19#2371. Add tests for factory constructor generating an enum value (dart-lang/co19#2376)
2023-11-15 sgrekhov22@gmail.com dart-lang/co19#2371. Add missing enhanced enums tests, update assertions (dart-lang/co19#2374)
2023-11-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2369. Static type of == operator is always bool (dart-lang/co19#2370)
2023-11-14 sgrekhov22@gmail.com dart-lang/co19#2303. Add more File.create()/createSync() tests (dart-lang/co19#2337)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2339. Add test for extension named type and a record type (dart-lang/co19#2366)

Change-Id: If608421c5a4f614187a66dc05fa5d8d90c9e363d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336901
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @johnniwinther