Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests require an update due to the recent changes in the nullability rules for extension types #2359

Closed
chloestefantsova opened this issue Nov 7, 2023 · 0 comments
Closed

Some tests require an update due to the recent changes in the nullability rules for extension types #2359

chloestefantsova opened this issue Nov 7, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@chloestefantsova
Copy link
Contributor

chloestefantsova commented Nov 7, 2023 •
edited

The following tests need to be updated in accordance with dart-lang/language#3434.

  • co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A03_t02
  • co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A17_t01
  • co19/LanguageFeatures/Extension-types/upper_bound_A01_t03
  • co19/LanguageFeatures/Extension-types/upper_bound_A01_t05
  • co19/LanguageFeatures/Extension-types/upper_bound_A01_t06
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_arguments_binding_A02_t01
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_arguments_binding_A02_t02
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_arguments_binding_A02_t03
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_class_member_A02_t01
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_class_member_A02_t02
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_class_member_A02_t03
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_global_variable_A02_t01
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_local_variable_A02_t01
  • co19/LanguageFeatures/Subtyping/static/generated/extension_type_return_value_A02_t01
  • co19/LanguageFeatures/Extension-types/nullability_A02_t01

This was detected while working on the update to the CFE implementing the spec update: https://dart-review.googlesource.com/c/sdk/+/333500.
@sgrekhov sgrekhov self-assigned this Nov 8, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 8, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 8, 2023
@sgrekhov
dart-lang#2359. Update tests according to the new nullability rules. …
cec4296 
…Part 1
@sgrekhov sgrekhov mentioned this issue Nov 8, 2023
Merged
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 8, 2023
@sgrekhov
dart-lang#2359. Update tests according to the new nullability rules. …
2ee1d52 
…Part 2
eernstg pushed a commit that referenced this issue Nov 8, 2023
@sgrekhov
#2359. Update tests according to the new nullability rules. Part 1 (#…
c48470e 
…2360)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 10, 2023
@sgrekhov
[co19] Roll co19 to 306f82e85b3d9e596eed38d36cbef369643515c0
8bcb6ec 
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2361. Improve some flaky tests on Web (dart-lang/co19#2364)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests. Part 3 (dart-lang/co19#2363)
2023-11-09 sgrekhov22@gmail.com dart-lang/co19#2349. Add more tests for constant constructors of the extension types (dart-lang/co19#2352)
2023-11-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2361. Fix flaky tests on web-platforms (dart-lang/co19#2362)
2023-11-08 sgrekhov22@gmail.com dart-lang/co19#2359. Update tests according to the new nullability rules. Part 1 (dart-lang/co19#2360)
2023-11-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix return type of `this` (dart-lang/co19#2358)
2023-11-07 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 2 (dart-lang/co19#2357)
2023-11-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2339. Add tests that extension can't have name `type` (dart-lang/co19#2340)
2023-11-03 sgrekhov22@gmail.com dart-lang/co19#2346. Add expected error in analyzer (dart-lang/co19#2347)

Change-Id: I6c0e1e9612dc4a0e21c4d506fa682ae1e9b98ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335461
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 14, 2023
@sgrekhov
dart-lang#2359. Fix existing extension types tests according to the n…
dd32e6a 
…ew nullability rules
eernstg pushed a commit that referenced this issue Nov 16, 2023
@sgrekhov
#2359. Fix existing extension types tests according to the new nullab…
5864263 
…ility rules (#2372)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 17, 2023
@sgrekhov
[co19] Roll co19 to 460758bf4c298812d47b24f7e5040c75088c3ebf
55a2b1c 
2023-11-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2381. Fix roll failures (dart-lang/co19#2382)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2379. Update expected error position for CFE (dart-lang/co19#2380)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2377. Add missing Float32x4List.setAll_A04_t01 test (dart-lang/co19#2378)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2373. Expect additional errors in CFE for member conflicts tests (dart-lang/co19#2375)
2023-11-16 sgrekhov22@gmail.com dart-lang/co19#2359. Fix existing extension types tests according to the new nullability rules (dart-lang/co19#2372)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix nullability in dynamic_semantics_member_invocation_A03_t02.dart (dart-lang/co19#2368)
2023-11-16 sgrekhov22@gmail.com dart-lang/co19#2371. Add tests for factory constructor generating an enum value (dart-lang/co19#2376)
2023-11-15 sgrekhov22@gmail.com dart-lang/co19#2371. Add missing enhanced enums tests, update assertions (dart-lang/co19#2374)
2023-11-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2369. Static type of == operator is always bool (dart-lang/co19#2370)
2023-11-14 sgrekhov22@gmail.com dart-lang/co19#2303. Add more File.create()/createSync() tests (dart-lang/co19#2337)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2339. Add test for extension named type and a record type (dart-lang/co19#2366)

Change-Id: If608421c5a4f614187a66dc05fa5d8d90c9e363d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336901
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @sgrekhov