Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension can't have name type #2339

Closed
sgrekhov opened this issue Nov 1, 2023 · 0 comments
Closed

Extension can't have name type #2339

sgrekhov opened this issue Nov 1, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 1, 2023

Add tests checking that extension can't have name type. See dart-lang/language#3431
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 1, 2023
@sgrekhov sgrekhov self-assigned this Nov 1, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 1, 2023
@sgrekhov
Fixes dart-lang#2339. Add tests that extension can't have name type
3d8e931
@eernstg eernstg closed this as completed in 7ccb121 Nov 3, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 10, 2023
@sgrekhov
dart-lang#2339. Add test for extension named type and a record type
1d56638
eernstg pushed a commit that referenced this issue Nov 10, 2023
@sgrekhov
#2339. Add test for extension named type and a record type (#2366)
36f6ee9 
Add test for extension named `type` and a record type
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 10, 2023
@sgrekhov
[co19] Roll co19 to 306f82e85b3d9e596eed38d36cbef369643515c0
8bcb6ec 
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2361. Improve some flaky tests on Web (dart-lang/co19#2364)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests. Part 3 (dart-lang/co19#2363)
2023-11-09 sgrekhov22@gmail.com dart-lang/co19#2349. Add more tests for constant constructors of the extension types (dart-lang/co19#2352)
2023-11-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2361. Fix flaky tests on web-platforms (dart-lang/co19#2362)
2023-11-08 sgrekhov22@gmail.com dart-lang/co19#2359. Update tests according to the new nullability rules. Part 1 (dart-lang/co19#2360)
2023-11-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix return type of `this` (dart-lang/co19#2358)
2023-11-07 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 2 (dart-lang/co19#2357)
2023-11-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2339. Add tests that extension can't have name `type` (dart-lang/co19#2340)
2023-11-03 sgrekhov22@gmail.com dart-lang/co19#2346. Add expected error in analyzer (dart-lang/co19#2347)

Change-Id: I6c0e1e9612dc4a0e21c4d506fa682ae1e9b98ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335461
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 17, 2023
@sgrekhov
[co19] Roll co19 to 460758bf4c298812d47b24f7e5040c75088c3ebf
55a2b1c 
2023-11-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2381. Fix roll failures (dart-lang/co19#2382)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2379. Update expected error position for CFE (dart-lang/co19#2380)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2377. Add missing Float32x4List.setAll_A04_t01 test (dart-lang/co19#2378)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2373. Expect additional errors in CFE for member conflicts tests (dart-lang/co19#2375)
2023-11-16 sgrekhov22@gmail.com dart-lang/co19#2359. Fix existing extension types tests according to the new nullability rules (dart-lang/co19#2372)
2023-11-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix nullability in dynamic_semantics_member_invocation_A03_t02.dart (dart-lang/co19#2368)
2023-11-16 sgrekhov22@gmail.com dart-lang/co19#2371. Add tests for factory constructor generating an enum value (dart-lang/co19#2376)
2023-11-15 sgrekhov22@gmail.com dart-lang/co19#2371. Add missing enhanced enums tests, update assertions (dart-lang/co19#2374)
2023-11-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2369. Static type of == operator is always bool (dart-lang/co19#2370)
2023-11-14 sgrekhov22@gmail.com dart-lang/co19#2303. Add more File.create()/createSync() tests (dart-lang/co19#2337)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2339. Add test for extension named type and a record type (dart-lang/co19#2366)

Change-Id: If608421c5a4f614187a66dc05fa5d8d90c9e363d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336901
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 13, 2024
@sgrekhov
dart-lang#2339. Add more tests for the extension method with the name…
75eb754 
… `type`
eernstg pushed a commit that referenced this issue Feb 13, 2024
@sgrekhov
#2339. Add more tests for the extension method with the name type (#…
ed8e9db 
…2542)

Note that these tests have intentional syntax errors.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2339. Add more tests for the extension method with the name…
478e635 
… `type` (dart-lang#2542)

Note that these tests have intentional syntax errors.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2339. Add more tests for the extension method with the name…
ef989bc 
… `type` (dart-lang#2542)

Note that these tests have intentional syntax errors.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 21, 2024
@sgrekhov
[co19] Roll co19 to 867d139b3169fc131488e893ec1133dc98cc3aa0
5e83b53 
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2496. Add missing part file (dart-lang/co19#2552)
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 2 (dart-lang/co19#2551)
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 1 (dart-lang/co19#2550)
2024-02-19 sgrekhov22@gmail.com Fix dart-lang/co19#2546. Add constant context tests (dart-lang/co19#2547)
2024-02-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2496. Fix co19 tests that became failing after test runner update (dart-lang/co19#2497)
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400. Add cascade operator test and more constants tests (dart-lang/co19#2545)
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests (dart-lang/co19#2543)
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400. Add representation variable initialization test (dart-lang/co19#2544)
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unsupported element from Stream.first/lastWhere tests description (dart-lang/co19#2540)
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unsupported element from ReceivePort.first/lastWhere tests description (dart-lang/co19#2541)
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2339. Add more tests for the extension method with the name `type` (dart-lang/co19#2542)
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2535. Add patterns constants tests for extension types (dart-lang/co19#2539)
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2485. Update`as` and `is` expressions tests with a function type (dart-lang/co19#2538)
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2536. Fix use of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#2537)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unused code, add issues numbers (dart-lang/co19#2534)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Fix failing API core tests (dart-lang/co19#2533)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Delete API tests with compile-time errors (dart-lang/co19#2531)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Fix and enable Iterable/forEach_A03_t01 (dart-lang/co19#2532)

Change-Id: I03e721d3871d5bf2b9773fbf7ebadb2a1804a111
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353260
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov