Fix #2485. Updateas and is expressions tests with a function type
#2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Feb 12, 2024
| /// | ||
| /// @description Checks that any other token following the ambiguous > will make | ||
| /// the prior tokens be parsed as comma separated < and > operator invocations. | ||
| /// Test `as`, `as!` and `is` tokens |
There was a problem hiding this comment.
We can't promise that the prior tokens are parsed as anything specific (the parse might very well just fail entirely), we can only promise that they will not be parsed as a <postfixExpression> of the form <primary> <selector>* <typeArguments>.
In each specific case we may then determine that some other parse will succeed, or the term is a syntax error.
There was a problem hiding this comment.
Description updated and more cases added
sgrekhov
commented
Feb 12, 2024
| /// | ||
| /// @description Checks that any other token following the ambiguous > will make | ||
| /// the prior tokens be parsed as comma separated < and > operator invocations. | ||
| /// Test `as`, `as!` and `is` tokens |
There was a problem hiding this comment.
Description updated and more cases added
Remove 2nd copy of spuriously duplicated line.
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 15, 2024
…tion type (dart-lang#2538) Update`as` and `is` expressions tests with a function type
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 15, 2024
…tion type (dart-lang#2538) Update`as` and `is` expressions tests with a function type
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 21, 2024
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2496. Add missing part file (dart-lang/co19#2552) 2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 2 (dart-lang/co19#2551) 2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 1 (dart-lang/co19#2550) 2024-02-19 sgrekhov22@gmail.com Fix dart-lang/co19#2546. Add constant context tests (dart-lang/co19#2547) 2024-02-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2496. Fix co19 tests that became failing after test runner update (dart-lang/co19#2497) 2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400. Add cascade operator test and more constants tests (dart-lang/co19#2545) 2024-02-14 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests (dart-lang/co19#2543) 2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400. Add representation variable initialization test (dart-lang/co19#2544) 2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unsupported element from Stream.first/lastWhere tests description (dart-lang/co19#2540) 2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unsupported element from ReceivePort.first/lastWhere tests description (dart-lang/co19#2541) 2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2339. Add more tests for the extension method with the name `type` (dart-lang/co19#2542) 2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2535. Add patterns constants tests for extension types (dart-lang/co19#2539) 2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2485. Update`as` and `is` expressions tests with a function type (dart-lang/co19#2538) 2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2536. Fix use of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#2537) 2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unused code, add issues numbers (dart-lang/co19#2534) 2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Fix failing API core tests (dart-lang/co19#2533) 2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Delete API tests with compile-time errors (dart-lang/co19#2531) 2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Fix and enable Iterable/forEach_A03_t01 (dart-lang/co19#2532) Change-Id: I03e721d3871d5bf2b9773fbf7ebadb2a1804a111 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353260 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.