Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update factory constructors tests according to the changed specification #2350

Closed
sgrekhov opened this issue Nov 3, 2023 · 1 comment
Closed

Update factory constructors tests according to the changed specification #2350

sgrekhov opened this issue Nov 3, 2023 · 1 comment
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 3, 2023

The current factory constructors tests are mainly written in 2011 and don't check a lot of the statements in the current spec. In particular there are no tests for enums. Need to update them and add missed tests
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 3, 2023
@sgrekhov sgrekhov self-assigned this Nov 3, 2023
@sgrekhov sgrekhov mentioned this issue Nov 3, 2023
Closed
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 6, 2023
@sgrekhov
dart-lang#2350. Update existing factory constructor tests
8a3c7ae
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 7, 2023
@sgrekhov
dart-lang#2350. Update existing factory constructor tests. Part 2
e6b3629
eernstg pushed a commit that referenced this issue Nov 7, 2023
@sgrekhov
#2350. Update existing factory constructor tests. Part 2 (#2357)
d3d4eb6 
Update existing factory constructor tests. Part 2
@sgrekhov sgrekhov mentioned this issue Nov 9, 2023
Closed
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 9, 2023
@sgrekhov
dart-lang#2350. Add more factory constructor tests. Part 3
7ed0586
eernstg pushed a commit that referenced this issue Nov 10, 2023
@sgrekhov
#2350. Add more factory constructor tests. Part 3 (#2363)
c4ca3b7 
Add more factory constructor tests. Part 3
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 10, 2023
@sgrekhov
[co19] Roll co19 to 306f82e85b3d9e596eed38d36cbef369643515c0
8bcb6ec 
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2361. Improve some flaky tests on Web (dart-lang/co19#2364)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests. Part 3 (dart-lang/co19#2363)
2023-11-09 sgrekhov22@gmail.com dart-lang/co19#2349. Add more tests for constant constructors of the extension types (dart-lang/co19#2352)
2023-11-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2361. Fix flaky tests on web-platforms (dart-lang/co19#2362)
2023-11-08 sgrekhov22@gmail.com dart-lang/co19#2359. Update tests according to the new nullability rules. Part 1 (dart-lang/co19#2360)
2023-11-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix return type of `this` (dart-lang/co19#2358)
2023-11-07 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 2 (dart-lang/co19#2357)
2023-11-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2339. Add tests that extension can't have name `type` (dart-lang/co19#2340)
2023-11-03 sgrekhov22@gmail.com dart-lang/co19#2346. Add expected error in analyzer (dart-lang/co19#2347)

Change-Id: I6c0e1e9612dc4a0e21c4d506fa682ae1e9b98ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335461
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 13, 2023
@sgrekhov
dart-lang#2350. Add/update factory constructor tests. Part 4
830714d
eernstg pushed a commit that referenced this issue Nov 28, 2023
@sgrekhov
#2350. Update existing factory constructor tests. Part 1 (#2353)
aab1a55 
Update existing factory constructor tests
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to 2ba55b45d85fece505a503dd12cf1c708825b74f
a3d5e1d 
2023-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.13.0 to 4.0.0 (dart-lang/co19#2410)
2023-12-01 sgrekhov22@gmail.com dart-lang/co19#2398. Update async tests to avoid false-positive results on web. Language and LanguageFeatures tests (dart-lang/co19#2407)
2023-12-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2408. Fix roll failures (dart-lang/co19#2409)
2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Update asyncStart/End() to correspond SDK version. Replace asyncMultiTest (dart-lang/co19#2406)
2023-11-30 sgrekhov22@gmail.com dart-lang/co19#2398. Remove excessive async. Add explicit `void` (dart-lang/co19#2400)
2023-11-28 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 1 (dart-lang/co19#2353)
2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Add expected error to static_analysis_extension_types_A30_t02.dart (dart-lang/co19#2401)
2023-11-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2399. Update expected errors locations for CFE (dart-lang/co19#2402)
2023-11-24 sgrekhov22@gmail.com dart-lang/co19#2388. Rename and reorder static_analysis_member_invocation_A06_t* tests (dart-lang/co19#2397)

Change-Id: Ie4b51caa12a9a0896c893cc02b099a07ef09fbd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339560
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
eernstg pushed a commit that referenced this issue Dec 13, 2023
@sgrekhov
#2350. Add/update factory constructor tests. Part 4 (#2367)
d5d1df8 
Add/update factory constructor tests. Part 4. Note that accessible_class_A01_t03 and redirecting_constructor_t0{2,3,6} have intentional syntax errors.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 13, 2023
@sgrekhov
dart-lang#2350. Add more factory constructors tests
241ad11
eernstg pushed a commit that referenced this issue Dec 13, 2023
@sgrekhov
#2350. Add more factory constructors tests (#2427)
ccffde6 
Add more factory constructors tests. Note that there are several intentional syntax errors.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 19, 2023
@sgrekhov
[co19] Roll co19 to b80c9a4cb6fb22b5c8a7395d532c8e461fe33ab9
8f6be08 
2023-12-19 sgrekhov22@gmail.com Fixes dart-lang/co19#2441. Fix roll failures (dart-lang/co19#2443)
2023-12-18 sgrekhov22@gmail.com Fixes dart-lang/co19#2435. Fix roll failures (dart-lang/co19#2437)
2023-12-18 sgrekhov22@gmail.com dart-lang/co19#2420. Add extension types exhaustiveness tests. Variables (dart-lang/co19#2431)
2023-12-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2430. Update expected errors positions for CFE (dart-lang/co19#2433)
2023-12-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2432. Remove excessive expected error for CFE (dart-lang/co19#2434)
2023-12-14 sgrekhov22@gmail.com dart-lang/co19#2420. Add extension types exhaustiveness tests. Maps (dart-lang/co19#2426)
2023-12-14 sgrekhov22@gmail.com dart-lang/co19#2420. Add extension types exhaustiveness tests. Lists (dart-lang/co19#2424)
2023-12-14 sgrekhov22@gmail.com dart-lang/co19#2139. Fix wrong failure of Language/Functions/element_type_A02_t06 (dart-lang/co19#2429)
2023-12-13 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructors tests (dart-lang/co19#2427)
2023-12-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2415. Update `StreamController.broadcast()` test according to the changed documentation (dart-lang/co19#2425)
2023-12-13 sgrekhov22@gmail.com dart-lang/co19#2350. Add/update factory constructor tests. Part 4 (dart-lang/co19#2367)
2023-12-12 sgrekhov22@gmail.com dart-lang/co19#2420. Add extension types exhaustiveness tests. Enums, trivial cases (dart-lang/co19#2423)
2023-12-11 sgrekhov22@gmail.com dart-lang/co19#2420. Add extension types exhaustiveness tests. Enums (dart-lang/co19#2422)
2023-12-11 sgrekhov22@gmail.com dart-lang/co19#2386. Rename well-bounded tests. Update descriptions (dart-lang/co19#2405)
2023-12-08 sgrekhov22@gmail.com dart-lang/co19#2415. Change expectations for Stream.asyncMap() according to the current behavior (dart-lang/co19#2421)

Change-Id: I777eba4f1615c8477a5d2044f295696dfc210b1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342582
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 13, 2024
@sgrekhov
dart-lang#2350. Add more factory constructor tests
82b8080
eernstg pushed a commit that referenced this issue Feb 14, 2024
@sgrekhov
#2350. Add more factory constructor tests (#2543)
5855642 
Add more factory constructor tests
@sgrekhov
Copy link
Contributor Author

Completed

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2350. Add more factory constructor tests (dart-lang#2543)
c059f5b 
Add more factory constructor tests
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2350. Add more factory constructor tests (dart-lang#2543)
b6c6b27 
Add more factory constructor tests
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 21, 2024
@sgrekhov
[co19] Roll co19 to 867d139b3169fc131488e893ec1133dc98cc3aa0
5e83b53 
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2496. Add missing part file (dart-lang/co19#2552)
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 2 (dart-lang/co19#2551)
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 1 (dart-lang/co19#2550)
2024-02-19 sgrekhov22@gmail.com Fix dart-lang/co19#2546. Add constant context tests (dart-lang/co19#2547)
2024-02-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2496. Fix co19 tests that became failing after test runner update (dart-lang/co19#2497)
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400. Add cascade operator test and more constants tests (dart-lang/co19#2545)
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests (dart-lang/co19#2543)
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400. Add representation variable initialization test (dart-lang/co19#2544)
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unsupported element from Stream.first/lastWhere tests description (dart-lang/co19#2540)
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unsupported element from ReceivePort.first/lastWhere tests description (dart-lang/co19#2541)
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2339. Add more tests for the extension method with the name `type` (dart-lang/co19#2542)
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2535. Add patterns constants tests for extension types (dart-lang/co19#2539)
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2485. Update`as` and `is` expressions tests with a function type (dart-lang/co19#2538)
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2536. Fix use of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#2537)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2119. Remove unused code, add issues numbers (dart-lang/co19#2534)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Fix failing API core tests (dart-lang/co19#2533)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Delete API tests with compile-time errors (dart-lang/co19#2531)
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529. Fix and enable Iterable/forEach_A03_t01 (dart-lang/co19#2532)

Change-Id: I03e721d3871d5bf2b9773fbf7ebadb2a1804a111
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353260
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov