Fixes #2574. Expect an error in case of augmenting a type alias #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Apr 30, 2024
There was a problem hiding this comment.
I think this one needs to be revisited. It contains a bunch of tests that we'd expect to succeed (so in that sense they are fine), but the tests seem to embody an assumption about how it works that isn't precise. I wrote a longer comment below to give more detail about why I came up with that view on things.
LanguageFeatures/Augmentation-libraries/augmenting_types_A01_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A01_t03.dart
Outdated
Show resolved
Hide resolved
|
Thank you for the detailed explanation. Tests updated and hopefully now it's clearer what exactly is tested. Please take another look |
eernstg
reviewed
May 1, 2024
LanguageFeatures/Augmentation-libraries/augmenting_types_A01_t03.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 3, 2024
2024-05-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2635. Use null-aware operator to invoke function via nullable variable (dart-lang/co19#2636) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for local variables in field initializers (dart-lang/co19#2634) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for local variables inside of getters and setters (dart-lang/co19#2633) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for functions (dart-lang/co19#2630) 2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.4 (dart-lang/co19#2632) 2024-05-01 sgrekhov22@gmail.com dart-lang/co19#2559. Make more augmented expression tests stronger (dart-lang/co19#2629) 2024-05-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2574. Expect an error in case of augmenting a type alias (dart-lang/co19#2627) 2024-04-30 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting expression tests for fields with no initializers (dart-lang/co19#2626) 2024-04-30 sgrekhov22@gmail.com dart-lang/co19#2559. Make augmented expression tests stronger (dart-lang/co19#2628) 2024-04-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2624. Add more extension type tests for union types (dart-lang/co19#2625) 2024-04-26 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting expression tests for fields (dart-lang/co19#2621) Change-Id: I8246f841afd24390742ba225e769ba881dccef9b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365261 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.