-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2559. Add more augmented expression tests for local variables inside of getters and setters #2633
Conversation
…es in getters and setters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One thing, I think we have to change var augmented() => "SomeString";
which occurs many times, because var
can't be the return type.
Then there's a real nit: In some cases where a parenthesized pattern is used in a declaration, the initializing expression is parenthesized as well. That looks like a misunderstanding, even though I do understand that it doesn't hurt anybody. Anyway, I wrote a comment on that, too. ;-)
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t11_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t11_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A01_t13_lib.dart
Show resolved
Hide resolved
Updated. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
2024-05-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2635. Use null-aware operator to invoke function via nullable variable (dart-lang/co19#2636) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for local variables in field initializers (dart-lang/co19#2634) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for local variables inside of getters and setters (dart-lang/co19#2633) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for functions (dart-lang/co19#2630) 2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.4 (dart-lang/co19#2632) 2024-05-01 sgrekhov22@gmail.com dart-lang/co19#2559. Make more augmented expression tests stronger (dart-lang/co19#2629) 2024-05-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2574. Expect an error in case of augmenting a type alias (dart-lang/co19#2627) 2024-04-30 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting expression tests for fields with no initializers (dart-lang/co19#2626) 2024-04-30 sgrekhov22@gmail.com dart-lang/co19#2559. Make augmented expression tests stronger (dart-lang/co19#2628) 2024-04-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2624. Add more extension type tests for union types (dart-lang/co19#2625) 2024-04-26 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting expression tests for fields (dart-lang/co19#2621) Change-Id: I8246f841afd24390742ba225e769ba881dccef9b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365261 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
No description provided.