-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2559. Add augmented expression tests for functions #2630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One test seems to be different from the stated purpose in the @description
, though, and perhaps it doesn't actually fit into this PR at all.
LanguageFeatures/Augmentation-libraries/augmented_expression_A04_t02_lib.dart
Show resolved
Hide resolved
Forgot to update (copy-paste caused error). Fixed.
That's cool! We didn't check it! Thank you for noticing! Added to this part, will add to other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
There is one word in several tests that I think should be changed, PTAL..
LanguageFeatures/Augmentation-libraries/augmented_expression_A04_t04_lib.dart
Outdated
Show resolved
Hide resolved
Typo fixed. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add missing semicolons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(added a couple of missing semicolons)
2024-05-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2635. Use null-aware operator to invoke function via nullable variable (dart-lang/co19#2636) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for local variables in field initializers (dart-lang/co19#2634) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for local variables inside of getters and setters (dart-lang/co19#2633) 2024-05-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for functions (dart-lang/co19#2630) 2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.4 (dart-lang/co19#2632) 2024-05-01 sgrekhov22@gmail.com dart-lang/co19#2559. Make more augmented expression tests stronger (dart-lang/co19#2629) 2024-05-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2574. Expect an error in case of augmenting a type alias (dart-lang/co19#2627) 2024-04-30 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting expression tests for fields with no initializers (dart-lang/co19#2626) 2024-04-30 sgrekhov22@gmail.com dart-lang/co19#2559. Make augmented expression tests stronger (dart-lang/co19#2628) 2024-04-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2624. Add more extension type tests for union types (dart-lang/co19#2625) 2024-04-26 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting expression tests for fields (dart-lang/co19#2621) Change-Id: I8246f841afd24390742ba225e769ba881dccef9b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365261 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
No description provided.