Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert breaking change in 13.10 #304

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Revert breaking change in 13.10 #304

merged 4 commits into from
Jun 4, 2020

Conversation

grouma
Copy link
Member

@grouma grouma commented Jun 4, 2020

No description provided.

@grouma grouma requested a review from jakemac53 June 4, 2020 16:21
jakemac53
jakemac53 reviewed Jun 4, 2020
View reviewed changes
CHANGELOG.md
## 0.13.10 - 2020-06-03

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a note that this is a broken release that was reverted here

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 87.599% when pulling 07ea320 on revert into 5142786 on master.

@grouma grouma merged commit 49219fc into master Jun 4, 2020
@grouma grouma deleted the revert branch June 4, 2020 16:25
grouma added a commit that referenced this pull request Jun 4, 2020
@grouma
Revert "Revert breaking change in 13.10 (#304)"
7e4df54 
This reverts commit 49219fc.
@grouma grouma mentioned this pull request Jun 4, 2020
Merged
grouma added a commit that referenced this pull request Jun 4, 2020
@grouma
Revert the 0.13.11 revert and properly model it as a breaking change (#…
7e18328 
…305)

* Revert "Revert breaking change in 13.10 (#304)"

This reverts commit 49219fc.

* update version and changelog

* pin test

* remove overrides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grouma @coveralls @jakemac53 @googlebot