-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to ignore lines from coverage depending on the comment #302
Conversation
Use // coverage:ignore-line to ignore one line. Use // coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive. Use // coverage:ignore-file to ignore the whole file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a CHANGELOG
entry and rev the package version.
Should we add a entry to README also about this ? |
Probably a good idea. Otherwise LGTM. |
Is this available on the current stable which is |
This should be available in stable as it depends on version 14.1: https://github.com/flutter/flutter/blob/78910062997c3a836feee883712c241a5fd22983/packages/flutter_tools/pubspec.yaml#L17 |
I'm on Flutter Is this known to work? Am I missing a configuration step? Entire file // coverage:ignore-file
import 'package:permission_handler/permission_handler.dart';
import 'package:permission_handler/permission_handler.dart' as permissionHandler
show openAppSettings;
/// A mockable interface for `permission_handler` package.
class PermissionsService {
/// Check the status of a specific [Permission]
Future<PermissionStatus> status(Permission permission) {
return permission.status;
}
/// Open the app settings.
Future<bool> openAppSettings() {
return permissionHandler.openAppSettings();
}
/// Request permissions for a single permission.
Future<PermissionStatus> request(Permission permission) {
return permission.request();
}
} |
@lukepighetti I tried to reproduce your issue and I'm unable to do so. I simply ran |
Use // coverage:ignore-line to ignore one line.
Use // coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive.
Use // coverage:ignore-file to ignore the whole file.