Deprecate unused packageImports field in analysis response (#2756)

* Remove unused packageImports field in analysis response * Make packageImports nullable and continue to supply on the backend
dart-lang · Dec 19, 2023 · 7e7f533 · 7e7f533
1 parent 270f9d9
commit 7e7f533
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 16 deletions.
diff --git a/pkgs/dart_services/lib/src/analysis.dart b/pkgs/dart_services/lib/src/analysis.dart
@@ -350,10 +350,7 @@ class AnalysisServerWrapper {
         ...importIssues,
         ...issues,
       ],
-      packageImports: imports
-          .where((import) => import.packageImport)
-          .map((import) => import.packageName)
-          .toList(),
+      packageImports: [],
     );
   }
 

diff --git a/pkgs/dart_services/lib/src/shared/model.dart b/pkgs/dart_services/lib/src/shared/model.dart
diff --git a/pkgs/dart_services/lib/src/shared/model.g.dart b/pkgs/dart_services/lib/src/shared/model.g.dart
diff --git a/pkgs/dart_services/test/server_test.dart b/pkgs/dart_services/test/server_test.dart
@@ -76,7 +76,7 @@ class MyApp extends StatelessWidget {
 
       expect(result, isNotNull);
       expect(result.issues, isEmpty);
-      expect(result.packageImports, contains('flutter'));
+      expect(result.packageImports, isEmpty);
     });
 
     test('analyze errors', () async {

diff --git a/pkgs/dartpad_shared/lib/model.dart b/pkgs/dartpad_shared/lib/model.dart
@@ -25,11 +25,13 @@ class SourceRequest {
 @JsonSerializable()
 class AnalysisResponse {
   final List<AnalysisIssue> issues;
-  final List<String> packageImports;
+
+  @Deprecated('This field was unused and will be removed in a future update.')
+  final List<String>? packageImports;
 
   AnalysisResponse({
     required this.issues,
-    required this.packageImports,
+    this.packageImports,
   });
 
   factory AnalysisResponse.fromJson(Map<String, dynamic> json) =>

diff --git a/pkgs/dartpad_shared/lib/model.g.dart b/pkgs/dartpad_shared/lib/model.g.dart
diff --git a/pkgs/sketch_pad/lib/model.dart b/pkgs/sketch_pad/lib/model.dart
@@ -40,7 +40,6 @@ class AppModel {
   final ValueNotifier<bool> appReady = ValueNotifier(false);
 
   final ValueNotifier<List<AnalysisIssue>> analysisIssues = ValueNotifier([]);
-  final ValueNotifier<List<String>> packageImports = ValueNotifier([]);
 
   final ValueNotifier<String> title = ValueNotifier('');
 
@@ -318,7 +317,6 @@ class AppServices {
         SourceRequest(source: appModel.sourceCodeController.text),
       );
       appModel.analysisIssues.value = results.issues;
-      appModel.packageImports.value = results.packageImports;
     } catch (error) {
       appModel.analysisIssues.value = [
         AnalysisIssue(
@@ -327,7 +325,6 @@ class AppServices {
           location: Location(line: 0, column: 0),
         ),
       ];
-      appModel.packageImports.value = [];
     }
   }