Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused packageImports field in analysis response #2756

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

parlough
Copy link
Member

We didn't end up using this, so let's deprecate it for now and likely remove it soon.

@parlough parlough changed the title Remove unused packageImports field in analysis response Deprecate unused packageImports field in analysis response Dec 15, 2023
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ the noted changes

pkgs/dartpad_shared/lib/model.dart Outdated Show resolved Hide resolved
pkgs/dart_services/lib/src/analysis.dart Show resolved Hide resolved
@devoncarew devoncarew merged commit 7e7f533 into main Dec 19, 2023
8 checks passed
@devoncarew devoncarew deleted the misc/remove-unused-package-imports-field branch December 19, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants