Fix menu contrast issue after color scheme changes (#2900)

dart-lang · Mar 18, 2024 · 7f2451a · 7f2451a
1 parent b2594ea
commit 7f2451a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/pkgs/sketch_pad/lib/main.dart b/pkgs/sketch_pad/lib/main.dart
@@ -139,13 +139,11 @@ class _DartPadAppState extends State<DartPadApp> {
       themeMode: themeMode,
       theme: ThemeData(
         useMaterial3: true,
-        colorScheme:
-            ColorScheme.fromSeed(seedColor: lightPrimaryColor).copyWith(
+        colorScheme: ColorScheme.fromSeed(
+          seedColor: lightPrimaryColor,
           surface: lightSurfaceColor,
           onSurface: Colors.black,
-          // TODO: Migrate to expanded Material 3 color palette.
-          // ignore: deprecated_member_use
-          surfaceVariant: lightSurfaceVariantColor,
+          surfaceContainerHighest: lightSurfaceVariantColor,
           onPrimary: lightLinkButtonColor,
         ),
         brightness: Brightness.light,
@@ -162,13 +160,12 @@ class _DartPadAppState extends State<DartPadApp> {
       ),
       darkTheme: ThemeData(
         useMaterial3: true,
-        colorScheme: ColorScheme.fromSeed(seedColor: darkPrimaryColor).copyWith(
+        colorScheme: ColorScheme.fromSeed(
+          seedColor: darkPrimaryColor,
           brightness: Brightness.dark,
           surface: darkSurfaceColor,
           onSurface: Colors.white,
-          // TODO: Migrate to expanded Material 3 color palette.
-          // ignore: deprecated_member_use
-          surfaceVariant: darkSurfaceVariantColor,
+          surfaceContainerHighest: darkSurfaceVariantColor,
           onSurfaceVariant: Colors.white,
           onPrimary: darkLinkButtonColor,
         ),

diff --git a/pkgs/sketch_pad/lib/problems.dart b/pkgs/sketch_pad/lib/problems.dart
@@ -43,9 +43,7 @@ class ProblemsTableWidget extends StatelessWidget {
       curve: animationCurve,
       child: Container(
         decoration: BoxDecoration(
-          // TODO: Migrate to expanded Material 3 color palette.
-          // ignore: deprecated_member_use
-          color: colorScheme.surfaceVariant,
+          color: colorScheme.surfaceContainerHighest,
         ),
         padding: const EdgeInsets.all(denseSpacing),
         child: ListView.builder(