comment out the 'unimplemented' find / find next messages (#2930)

dart-lang · Apr 3, 2024 · e8fdd4b · e8fdd4b
1 parent 91215f8
commit e8fdd4b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 27 deletions.
diff --git a/pkgs/sketch_pad/lib/keys.dart b/pkgs/sketch_pad/lib/keys.dart
@@ -24,16 +24,16 @@ final ShortcutActivator runKeyActivator2 = SingleActivator(
   control: _nonMac,
 );
 
-final ShortcutActivator findKeyActivator = SingleActivator(
-  LogicalKeyboardKey.keyF,
-  meta: _mac,
-  control: _nonMac,
-);
-final ShortcutActivator findNextKeyActivator = SingleActivator(
-  LogicalKeyboardKey.keyG,
-  meta: _mac,
-  control: _nonMac,
-);
+// final ShortcutActivator findKeyActivator = SingleActivator(
+//   LogicalKeyboardKey.keyF,
+//   meta: _mac,
+//   control: _nonMac,
+// );
+// final ShortcutActivator findNextKeyActivator = SingleActivator(
+//   LogicalKeyboardKey.keyG,
+//   meta: _mac,
+//   control: _nonMac,
+// );
 
 final ShortcutActivator formatKeyActivator1 = SingleActivator(
   LogicalKeyboardKey.keyS,
@@ -65,8 +65,8 @@ const ShortcutActivator quickFixKeyActivator2 = SingleActivator(
 
 final List<(String, List<ShortcutActivator>)> keyBindings = [
   ('Code completion', [codeCompletionKeyActivator]),
-  ('Find', [findKeyActivator]),
-  ('Find next', [findNextKeyActivator]),
+  // ('Find', [findKeyActivator]),
+  // ('Find next', [findNextKeyActivator]),
   ('Format', [formatKeyActivator1, formatKeyActivator2]),
   ('Quick fixes', [quickFixKeyActivator1, quickFixKeyActivator2]),
   ('Run', [runKeyActivator1, runKeyActivator2]),

diff --git a/pkgs/sketch_pad/lib/main.dart b/pkgs/sketch_pad/lib/main.dart
@@ -25,7 +25,6 @@ import 'model.dart';
 import 'problems.dart';
 import 'samples.g.dart';
 import 'theme.dart';
-import 'utils.dart';
 import 'versions.dart';
 import 'widgets.dart';
 
@@ -446,14 +445,14 @@ class _DartPadMainPageState extends State<DartPadMainPage>
             keys.runKeyActivator2: () {
               if (!appModel.compilingBusy.value) _performCompileAndRun();
             },
-            keys.findKeyActivator: () {
-              // TODO:
-              unimplemented(context, 'find');
-            },
-            keys.findNextKeyActivator: () {
-              // TODO:
-              unimplemented(context, 'find next');
-            },
+            // keys.findKeyActivator: () {
+            //   // TODO:
+            //   unimplemented(context, 'find');
+            // },
+            // keys.findNextKeyActivator: () {
+            //   // TODO:
+            //   unimplemented(context, 'find next');
+            // },
             keys.formatKeyActivator1: () {
               if (!appModel.formattingBusy.value) _handleFormatting();
             },

diff --git a/pkgs/sketch_pad/lib/utils.dart b/pkgs/sketch_pad/lib/utils.dart
@@ -20,12 +20,6 @@ String titleCase(String phrase) {
   return phrase.substring(0, 1).toUpperCase() + phrase.substring(1);
 }
 
-void unimplemented(BuildContext context, String message) {
-  ScaffoldMessenger.of(context).showSnackBar(
-    SnackBar(content: Text('Unimplemented: $message')),
-  );
-}
-
 String generateSnippetName() => fluttering_phrases.generate();
 
 RelativeRect calculatePopupMenuPosition(